Skip to content

Add IDiscoveryClient.InstancesFetched event#1672

Merged
bart-vmware merged 3 commits intomainfrom
discovery-fetch-event
Apr 15, 2026
Merged

Add IDiscoveryClient.InstancesFetched event#1672
bart-vmware merged 3 commits intomainfrom
discovery-fetch-event

Conversation

@bart-vmware
Copy link
Copy Markdown
Member

@bart-vmware bart-vmware commented Apr 14, 2026

Description

Adds IDiscoveryClient.InstancesFetched event that enables responding to changes in remote services and their instances.
Implemented for Eureka and configuration-based clients.

Reverts the change from #1666 that added taking UseNetworkInterfaces into account to determine Consul ports.

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware bart-vmware marked this pull request as ready for review April 14, 2026 16:57
@bart-vmware bart-vmware requested a review from TimHess April 14, 2026 16:57
@github-actions
Copy link
Copy Markdown
Contributor

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 100%
Steeltoe.Common 84.5% 77.8%
Steeltoe.Common.Certificates 97.2% 85.9%
Steeltoe.Common.Hosting 84% 70%
Steeltoe.Common.Http 100% 85.2%
Steeltoe.Common.Logging 81.1% 56.2%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 96.1% 90.7%
Steeltoe.Configuration.CloudFoundry 99.1% 91.8%
Steeltoe.Configuration.ConfigServer 90.7% 85.9%
Steeltoe.Configuration.Encryption 97.6% 92.4%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.1% 89.3%
Steeltoe.Configuration.Placeholder 93.8% 84.7%
Steeltoe.Configuration.RandomValue 93.2% 90%
Steeltoe.Configuration.SpringBoot 98.3% 95%
Steeltoe.Connectors 93.9% 89.4%
Steeltoe.Connectors.EntityFrameworkCore 81.5% 75%
Steeltoe.Discovery.Configuration 96.3% 91.6%
Steeltoe.Discovery.Consul 97.6% 96.5%
Steeltoe.Discovery.Eureka 92.2% 85.3%
Steeltoe.Discovery.HttpClients 94.3% 95.4%
Steeltoe.Logging.Abstractions 99.4% 96.9%
Steeltoe.Logging.DynamicConsole 100% 95.4%
Steeltoe.Logging.DynamicSerilog 99.1% 95.4%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 95.8% 89%
Steeltoe.Management.Prometheus 95.8% 91.6%
Steeltoe.Management.Tasks 100% ****
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 100%
Steeltoe.Security.Authentication.OpenIdConnect 73.8% 59%
Steeltoe.Security.Authorization.Certificate 96.7% 75%
Steeltoe.Security.DataProtection.Redis 100% ****

@sonarqubecloud
Copy link
Copy Markdown

Comment thread src/Discovery/src/Configuration/ConfigurationDiscoveryClient.cs
Comment thread src/Discovery/src/Configuration/ConfigurationDiscoveryClient.cs
Comment thread src/Common/src/Common/Discovery/IDiscoveryClient.cs
Comment thread src/Discovery/src/Configuration/ConfigurationDiscoveryClient.cs
Comment thread src/Discovery/src/Configuration/ConfigurationDiscoveryClient.cs
Comment thread src/Common/src/Common/Discovery/IDiscoveryClient.cs
@bart-vmware bart-vmware merged commit 5d88bb2 into main Apr 15, 2026
18 checks passed
@bart-vmware bart-vmware deleted the discovery-fetch-event branch April 15, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants