Conversation
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #253, I renamed the plugin from
protondb-library->protondb-library-badges. When updating the submodule, I renamed thepathin.gitmodulesbut missed the section name. CI looks up each submodule's URL by path, so this caused the store build to be skipped for this plugin. Installing from the store ID showed an "This plugin does not have a valid build for you OS" error from Millennium.This PR renames the
.gitmodulessection for this plugin toplugins/protondb-library-badgesso it matches the path. I've also included an empty commit in the plugin repo to bump the submodule pointer and trigger a store build.