Default fineMappingPipeline L to 10 and greedy-L off - #592
Merged
Merged
Conversation
fineMappingPipeline and .fmNormalizeMethods now default L to 10 (was 20) and Lgreedy to NULL (was 5), so the greedy-L loop is off unless a caller asks for it. Both stay overridable; passing Lgreedy = 5 reproduces the old default. Updated the two tests that checked the old filled-in defaults. The .twasMethodLookup path keeps its own L_greedy = 5 (separate code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fineMappingPipeline and .fmNormalizeMethods now default L to 10 (was 20) and Lgreedy to NULL (was 5), so the greedy-L loop is off unless a caller asks for it. Both stay overridable — pass L / Lgreedy, or a per-method L / L_greedy; passing Lgreedy = 5 reproduces the old default.
Updated the two tests that asserted the old filled-in defaults. The .twasMethodLookup path keeps its own L_greedy = 5 — separate code, out of scope.
Pairs with the RSS pipeline default change (xqtl-protocol #1422).