Repository navigation
discord-ci-notify v1: classify from needs (skipped = INCOMPLETE), tested scripts, release pinning; Actions audit 2026-10-12 - #1
Merged
Conversation
…pped job is INCOMPLETE, never success or RECOVERED), logic moved into tested scripts, a test workflow; README pins by release SHA; the 2026-10-12 Actions audit - classify.sh: any failure -> failure, else any cancelled -> cancelled, else any skipped -> incomplete, else success; the legacy `result` input still works (skipped -> incomplete). - notify.sh: the posting logic, unchanged for FAILED / RECOVERED / manual PASSED; INCOMPLETE posts name the jobs that never ran. - tests/test-notify.sh: 23 checks run by .github/workflows/test.yml, plus a no-webhook dry run of the action. - docs/ci-audit-2026-10-12.md: the cross-repo audit (confirmed issues C1-C12, proposals P1-P6, disposition). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ertr3dpdimU1VjCXXAJSBi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contains(needs.*.result, ...)expression reported a run with skipped jobs as success, and as RECOVERED after a red run. v1 takesneeds: ${{ toJSON(needs) }}and classifies: any failure → FAILED, else any cancelled → silent, else any skipped → INCOMPLETE (names the jobs that never ran; never a recovery), else success. FAILED / RECOVERED / manual PASSED behavior is unchanged. The legacyresultinput still works during migration.classify.sh/notify.sh, withtests/test-notify.sh(23 checks) and aTestworkflow (unit tests + a no-webhook dry run of the action).@main. After merge: tagdiscord-ci-notify-v1.0.0, then bump Arcane, Astra, Manifold2D and Mosaic.docs/ci-audit-2026-10-12.md: the cross-repo Actions audit.Test plan
tests/test-notify.shgreen in ubuntu:24.04 + jqTestworkflow green on this PR🤖 Generated with Claude Code
https://claude.ai/code/session_01Ertr3dpdimU1VjCXXAJSBi