Skip to content

Add support for C++17.#1

Open
willson556 wants to merge 1 commit into
mainfrom
feature/cpp17-support
Open

Add support for C++17.#1
willson556 wants to merge 1 commit into
mainfrom
feature/cpp17-support

Conversation

@willson556
Copy link
Copy Markdown
Member

@willson556 willson556 commented Jun 4, 2026

Description

Adds support for C++17 using preprocessor directives to disable unsupported features.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Performance improvement
  • Code refactoring
  • Build/CI configuration change
  • Other (please describe):

Related Issues

N/A

Changes Made

  • Added macros for [[likely]] and [[unlikely]] attributes (these weren't introduced until C++20)
  • Added NFX_STRINGBUILDER_HAS_STD_FORMAT define when std::format is available
  • Extended Actions workflows to build with both C++20 and C++17.

Testing

  • All existing tests pass
  • Added new tests for changes
  • Tested on Windows
  • Tested on Linux
  • Tested on macOS
  • Benchmarks run (if performance-related)

Test Configuration

  • Compiler(s):
  • CMake version:
  • Build type: Debug / Release / RelWithDebInfo

Documentation

  • Updated code comments
  • Updated Doxygen documentation
  • Updated README.md
  • Updated CHANGELOG.md
  • No documentation needed

Breaking Changes

N/A

Checklist

  • Code follows the project's coding style
  • Self-review of code completed
  • No compiler warnings introduced
  • Changes are properly documented
  • All tests pass locally
  • No unnecessary debug code or comments left behind
  • Commit messages are clear and descriptive

Screenshots / Output

Additional Notes

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@willson556 willson556 force-pushed the feature/cpp17-support branch from 16ab3fe to 153659d Compare June 4, 2026 20:19
@willson556 willson556 marked this pull request as ready for review June 4, 2026 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant