Use maintained YAML through Testify upgrade - #7
Open
ai-collaboration-app[bot] wants to merge 1 commit into
Open
ai-collaboration-app[bot] wants to merge 1 commit into
ai-collaboration-app[bot] wants to merge 1 commit into
Conversation
Upgrade the test assertion owner to v1.12.1, which uses go.yaml.in/yaml/v3. YAML is absent from this library production package graph. Eventually now polls immediately. Release the transaction read lock on every predicate return and report pending states through Eventually rather than failing during a successful wait. Tracking: StackVista/stackstate#717
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Testify to v1.12.1 so the test-only YAML dependency uses maintained
go.yaml.in/yaml/v3. Fix the existing transaction polling helper to release its read lock on pending states and tolerate Testify's immediate first check. Production packages do not link YAML.Tracking: https://github.com/StackVista/stackstate/issues/717
Validation: full Go tests, build, gofmt, module verification/tidy and revive passed (13 existing warnings). Consumer module graphs must be qualified separately; no replacement directives are introduced.