Bound feature queries and make polling cancellable by craffit · Pull Request #5 · StackVista/stackstate-receiver-go-client

craffit · 2026-09-14T12:49:19Z

Adds bounded, classified feature queries and cancellable polling on the merged transport foundation. HTTPS CONNECT 407 is a configuration failure; proxy 5xx remains retryable.

Client.StartPolling replaces StartFeaturesPoller; callers must migrate. The existing client constructor and Connect() remain available.

Validation: OpenAPI transport/feature race suites pass; revive reports no errors.

Tracking: https://github.com/StackVista/stackstate/issues/587

craffit · 2026-09-14T12:54:51Z

Updated the description to explain the connection checks and request limits in plain language. No code changes.

craffit · 2026-09-14T13:34:38Z

Added cancellable feature polling with delayed, jittered queries and delivery of successful and failed outcomes. Tests cover slow consumers, retry accounting, repeated stop and cancellation during HTTP, backoff, interval waits and blocked output. Focused race tests, the full Go suite and CI lint pass.

ai-collaboration-app

Reviewed as the root of the #587 chain (this PR → kubernetes-rbac-agent#13 → sts-opentelemetry-collector#181 → helm-charts-internal#205). Both consumers pin this exact commit, so no divergence there.

The two blockers are connectivity regressions rather than logic bugs: not following redirects and dropping proxy env vars each turn a working deployment into a fatal start, because both consumers treat Rejected/Authentication as unrecoverable. Worth settling here before the consumers adopt.

Positives worth keeping: the token is re-read per request so SA rotation works, Result deliberately retains no error or body so credentials can't leak into telemetry, and dropping the old isVerbose openapi debug removes a request/response logging path.

ai-collaboration-app · 2026-09-21T08:13:11Z

+
+func newTransport(opts ConnectionOptions) (http.RoundTripper, error) {
+	transport := http.DefaultTransport.(*http.Transport).Clone()
+	transport.Proxy = nil


Blocker. Clearing Proxy drops HTTPS_PROXY/NO_PROXY, so installs that reach the Receiver through a cluster-wide proxy env var lose connectivity silently after upgrade. Fall back to http.ProxyFromEnvironment when ProxyURL is empty.

The previous transport also configured only an explicit proxy; it did not use ProxyFromEnvironment. That policy is retained and documented in a78db13. TestProxyAndRedirectBoundaries passes for explicit proxying and isolation from ambient proxy settings.

Explicit proxy handling now lives in foundation #6 (f18c955), together with the additive options constructor. This PR retains only the feature-query/poller additions above it. Proxy and transport race tests pass on e2d867b.

ai-collaboration-app · 2026-09-21T08:13:11Z

+	if err != nil || values == nil {
+		return Malformed
+	}
+	if capability, present := values["otel-logs"]; present {


A shared client shouldn't hardcode one consumer's capability key — the RBAC agent's k8s-rbac gets no equivalent type check. Either move the expected keys into QueryOptions, or drop the check and let callers assert.

Fixed in a78db13 with copied QueryOptions.BooleanCapabilities. The HTTP matrix covers logs, RBAC, both keys and object-only queries, including malformed requested keys and preserved unrelated numeric values. Both consumers explicitly select their own key.

ai-collaboration-app · 2026-09-21T08:13:11Z

+			result.Class = contextClass(authCtx, queryCtx.Err())
+			break
+		}
+		delay := time.Duration(c.random() * float64(backoff))


This is full jitter, so a run of small random values retries almost immediately and the retry bound degrades to MaxAttempts back-to-back requests. A floor of backoff/2 would keep the spacing.

Full jitter is the selected retry policy, so near-zero delays are allowed. MaxAttempts and the whole-query deadline still bound requests, and Retry-After remains a minimum when present. Existing retry/deadline/cancellation tests pass; no minimum spacing is promised for retries.

craffit · 2026-09-21T13:44:52Z

Added consumer-specific boolean capability validation and compatibility documentation in a78db13. The HTTP matrix, options-copy test, race checks, full suite and gofmt pass; revive reports existing warnings only. RBAC #13 and Collector #181 consume the same pushed pseudo-version.

craffit · 2026-09-22T12:01:57Z

Step-7 handoff at a78db13: full-suite/lint CI and the refreshed focused race suite pass. All six inline threads have substantive replies.

Regarding the review summary: redirects are deliberately rejected, requiring the final Receiver URL. Explicit-only proxying predates this PR. Per-request credential rotation and bounded, redacted results remain covered. RBAC now waits through capability-query 401/403; the logs collector retains its separate startup policy.

Descriptions are updated; no new source changes. Receiver route/config tests were skipped by owner request, and live acceptance remains outstanding.

craffit · 2026-09-23T09:42:10Z

Stacked on #6 with signed merge e2d867b; reviewed history is preserved. Transport and legacy-constructor compatibility live in #6; this diff retains discovery, response bounds and polling. Full tests, feature/transport race tests and lint pass. Consumer pin: v0.0.0-20260923090625-e2d867b29448.

craffit · 2026-09-23T09:48:25Z

Integration review found that the feature-response wrapper hid idle-connection cleanup. a9d2a56 forwards CloseIdleConnections and adds a real HTTP shutdown regression test. Full tests, focused race tests and lint pass; consumers are updating to the corrected revision.

…ature-query # Conflicts: # pkg/openapiclient/options_test.go

craffit · 2026-09-23T14:03:35Z

Merged the #6 transport cleanup, removing CABundlePEM and using system certificate trust. Feature-query classification and polling behavior are retained. CI passed for f0ec060.

craffit · 2026-09-28T11:16:29Z

Merged A1's platform-aware system-trust test fix into this branch (3f3f517). The Linux certificate-trust subprocess test remains covered; non-Linux runs skip that Linux-specific mechanism. Focused client and feature-query race tests pass.

craffit · 2026-09-29T09:21:17Z

Merged master in signed commit 82c5cc1 and retargeted to master after #6 merged. Transport/feature race tests and current-head CI pass. Collector and RBAC now pin this revision.

LouisLotter

Follow-up review of the current head. The proxy CONNECT classification needs a fix before consumers are re-pinned; the compatibility wording is a nonblocking correction.

craffit · 2026-10-01T07:00:15Z

Fixed in f2036fa: preserve CONNECT status in a credential-safe typed error, classify 407 as configuration failure before generic transport errors, and retain bounded retries for proxy 5xx. Regression tests cover status/attempt counts and private response-text exclusion; OpenAPI race suites pass.

Also corrected the compatibility description: Client.StartPolling replaces StartFeaturesPoller; existing constructors remain available. Collector and RBAC are being re-pinned to this revision.

Add bounded Receiver feature queries

3c9289e

Make feature polling cancellable and preserve query outcomes

d9a8038

craffit changed the title ~~Add bounded Receiver feature queries~~ Bound feature queries and make polling cancellable Sep 14, 2026

ai-collaboration-app Bot reviewed Sep 21, 2026

View reviewed changes

ai-collaboration-app Bot mentioned this pull request Sep 21, 2026

Add capability discovery and native logs to the Filelog agent StackVista/sts-opentelemetry-collector#181

Merged

Validate capability types per consumer

a78db13

craffit mentioned this pull request Sep 22, 2026

Add shared Receiver transport for the Filelog agent #6

Merged

Merge transport foundation into feature client

e2d867b

craffit changed the base branch from master to receiver-transport September 23, 2026 09:42

Preserve idle connection cleanup through feature bounds

a9d2a56

Merge remote-tracking branch 'origin/receiver-transport' into otel-fe…

f0ec060

…ature-query # Conflicts: # pkg/openapiclient/options_test.go

Merge transport trust test fix

3f3f517

Merge master after transport foundation

82c5cc1

craffit changed the base branch from receiver-transport to master September 29, 2026 09:17

craffit marked this pull request as ready for review September 29, 2026 09:21

craffit commented Sep 29, 2026

View reviewed changes

Comment thread pkg/openapiclient/transport.go

Explain bounded feature response reads

736091f

LouisLotter reviewed Sep 30, 2026

View reviewed changes

Comment thread pkg/openapiclient/features/features_client.go

Comment thread pkg/openapiclient/features/features_poller.go

deontaljaard approved these changes Sep 30, 2026

View reviewed changes

Classify proxy CONNECT rejections before transport failures

f2036fa

craffit merged commit fd72bbd into master Oct 1, 2026
2 checks passed

Conversation

craffit commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

craffit commented Sep 14, 2026

Uh oh!

craffit commented Sep 14, 2026

Uh oh!

ai-collaboration-app Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ai-collaboration-app Bot Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

craffit Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

craffit Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ai-collaboration-app Bot Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

craffit Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ai-collaboration-app Bot Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

craffit Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

craffit commented Sep 21, 2026

Uh oh!

craffit commented Sep 22, 2026

Uh oh!

craffit commented Sep 23, 2026

Uh oh!

craffit commented Sep 23, 2026

Uh oh!

craffit commented Sep 23, 2026

Uh oh!

craffit commented Sep 28, 2026

Uh oh!

craffit commented Sep 29, 2026

Uh oh!

Uh oh!

LouisLotter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

craffit commented Oct 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

craffit commented Sep 14, 2026 •

edited

Loading