Skip inline-spec VolumeAttachments in the Kubernetes topology check - #539
Open
LouisParkin wants to merge 3 commits into
Open
LouisParkin wants to merge 3 commits into
LouisParkin wants to merge 3 commits into
Conversation
An attachment with inlineVolumeSpec has no persistentVolumeName; dereferencing it panicked the topology check.
The moving cacert.pem fails checksum verification whenever curl publishes a new bundle.
LouisLotter
approved these changes
Oct 1, 2026
LouisParkin
enabled auto-merge
October 1, 2026 13:59
github-merge-queue
Bot
removed this pull request from the merge queue due to invalid changes in the merge commit
Oct 1, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
VolumeAttachmentcan useinlineVolumeSpecinstead ofpersistentVolumeName(CSI migration of in-tree inline volumes), leaving the name nil. The persistent volume collector dereferenced it in both of its attachment loops, so any such attachment panicked the Kubernetes topology check. Those attachments are now skipped. There is no PersistentVolume component to relate them to, so the topology is unchanged.The new test mixes an inline attachment with a normal one: it panicked before the fix, and now passes with the normal attachment's node tag and node → PV relation intact.
Fixes #537
🤖 Generated with Claude Code