Fix data race in the topology relation cache - #538
Open
LouisParkin wants to merge 3 commits into
Open
LouisParkin wants to merge 3 commits into
LouisParkin wants to merge 3 commits into
Conversation
Collectors and correlators append to possibleRelations concurrently; the WaitGroup did not exclude them, so relations could be lost.
The moving cacert.pem fails checksum verification whenever curl publishes a new bundle.
LouisLotter
approved these changes
Oct 1, 2026
LouisParkin
enabled auto-merge
October 1, 2026 13:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SubmitRelationparks relations whose endpoints are not yet known inpossibleRelations. The collectors goroutine and the correlator goroutines append to that slice concurrently, and theWaitGrouparound the append did not exclude them, so relations could be lost from a topology snapshot. The cache now uses a mutex, andCorrelateRelationsreads a snapshot of the slice under it.The new test submits relations from 8 goroutines. Before the fix it reports data races under
-raceand loses relations; after the fix, the package tests pass under-race.Fixes #536
🤖 Generated with Claude Code