Skip to content

chore(bin/hubot): Removed hardcoded slack adapter #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wow0000 wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

chore(bin/hubot): Removed hardcoded slack adapter #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/hubot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ if [ ! -n "$HUBOT_ALIAS" ]; then
fi

# Keep st2chatops hack (ignored by hubot) for process discovery
exec $HERE/node_modules/.bin/hubot "$@" -a @hubot-friends/hubot-slack st2chatops

@skiedude skiedude Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To not break people who are relying on this hard-coded default, I'd set the default "HUBOT_ADAPTER" value in the st2chatops.env file to @hubot-friends/hubot-slack

@skiedude skiedude Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also all the testingenv/**/docker-entrypoint.sh need to be updated as well to work with that change

exec $HERE/node_modules/.bin/hubot "$@" -a "$HUBOT_ADAPTER" st2chatops