Skip to content

Qualify GitHub environment node names by repository - #78

Closed
jaredcatkinson wants to merge 1 commit into
mainfrom
feature/qualified-environment-name
Closed

jaredcatkinson wants to merge 1 commit into
mainfrom
feature/qualified-environment-name

Conversation

@jaredcatkinson

@jaredcatkinson jaredcatkinson commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Qualify GH_Environment.name with the repository full name, producing values such as org/repo/production.
  • Preserve the short environment name in displayname and short_name.
  • Match workflow deployment and OIDC edges using repository_id and short_name so those relationships continue to resolve.

Validation

  • Focused environment and workflow tests: 43 passed.
  • Ruff checks passed for the changed Python files.

Summary by CodeRabbit

  • Bug Fixes
    • Environments are now identified by both repository and environment name, preventing same-named environments in different repositories from being confused.
    • Workflow deployments and OIDC environment links now match environments by their short name within the repository.
    • The name shown in the interface remains unchanged.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: fbf1fffb-06eb-4976-a34c-8a6f45dad3d4

📥 Commits

Reviewing files that changed from the base of the PR and between 700f2db and a0028ab.

📒 Files selected for processing (6)
  • descriptions/nodes/GH_Environment.md
  • src/openhound_github/models/environment.py
  • src/openhound_github/models/workflow_job.py
  • tests/test_environment_model.py
  • tests/test_workflow_interception_path.py
  • tests/test_workflow_model.py
 _____________________________________________________________
< What, what, what, what, what, what, what, what, what, what? >
 -------------------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant