Skip to content

Conversation

@rvazarkar
Copy link
Contributor

@rvazarkar rvazarkar commented Nov 17, 2025

Description

see title

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Summary by CodeRabbit

  • Chores
    • Updated version to 4.5.1-rc1 (release candidate).

@coderabbitai
Copy link

coderabbitai bot commented Nov 17, 2025

Walkthrough

The pull request bumps the package version in src/CommonLib/SharpHoundCommonLib.csproj from 4.5.0 to 4.5.1-rc1. This is a single-file change with no modifications to project structure, dependencies, or code.

Changes

Cohort / File(s) Summary
Version Bump
src/CommonLib/SharpHoundCommonLib.csproj
Updated package version from 4.5.0 to 4.5.1-rc1

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • definitelynotagoblin
  • MikeX777
  • ktstrader

Poem

🐰 A tiny bump, from four to five,
Point-one-rc keeps the project alive,
Version strings dance in silent files,
Marking progress mile by mile,
One small change, one big stride! 🚀

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description is largely incomplete. While the author correctly identified it as a chore and checked that tests passed, the Motivation and Context and How Has This Been Tested sections lack substantive content. Add details about why this version bump was required, what testing was performed, and link to any related issues or release notes if applicable.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: bumping the package version to 4.5.1-rc1, which matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch version_bump_251rc1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 464f19d and cbe8385.

📒 Files selected for processing (1)
  • src/CommonLib/SharpHoundCommonLib.csproj (1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: definitelynotagoblin
Repo: SpecterOps/SharpHoundCommon PR: 229
File: .github/workflows/git-dev.yml:35-39
Timestamp: 2025-07-24T21:38:13.462Z
Learning: In the SpecterOps/SharpHoundCommon repository, the team prefers using `sleet push --force` to overwrite git-dev packages rather than creating unique versions with commit SHAs, as they want a single "current state" package for downstream consumers.
📚 Learning: 2025-10-17T13:43:46.833Z
Learnt from: MikeX777
Repo: SpecterOps/SharpHoundCommon PR: 241
File: src/CommonLib/Processors/LdapPropertyProcessor.cs:168-169
Timestamp: 2025-10-17T13:43:46.833Z
Learning: Properties added to dictionaries returned by methods in SharpHoundCommon (such as those in LdapPropertyProcessor) may be consumed by dependent projects like SharpHound (SH) and SharpHoundEnterprise (SHE), even if they are not used within the SharpHoundCommon repository itself.

Applied to files:

  • src/CommonLib/SharpHoundCommonLib.csproj
📚 Learning: 2025-07-24T21:38:13.462Z
Learnt from: definitelynotagoblin
Repo: SpecterOps/SharpHoundCommon PR: 229
File: .github/workflows/git-dev.yml:35-39
Timestamp: 2025-07-24T21:38:13.462Z
Learning: In the SpecterOps/SharpHoundCommon repository, the team prefers using `sleet push --force` to overwrite git-dev packages rather than creating unique versions with commit SHAs, as they want a single "current state" package for downstream consumers.

Applied to files:

  • src/CommonLib/SharpHoundCommonLib.csproj
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (1)
src/CommonLib/SharpHoundCommonLib.csproj (1)

12-12: Version bump to 4.5.1-rc1 is correct.

SharpHoundRPC and SharpHoundCommonLib are independent projects with no dependency relationship. The version change is properly scoped to CommonLib only, with no cross-codebase synchronization required.


Comment @coderabbitai help to get the list of available commands and usage tips.

@rvazarkar rvazarkar merged commit 7e67ec1 into v4 Nov 18, 2025
3 checks passed
@rvazarkar rvazarkar deleted the version_bump_251rc1 branch November 18, 2025 14:17
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants