Conversation
Bumps [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) from 9.39.4 to 10.0.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](https://github.com/eslint/eslint/commits/v10.0.1/packages/js) --- updated-dependencies: - dependency-name: "@eslint/js" dependency-version: 10.0.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Dependabot bumped @eslint/js to 10.0.1 (PR #75) but left eslint pinned at ^9.39.4. @eslint/js@10.0.1 declares peerOptional eslint ^10.0.0, so `npm ci` fails with ERESOLVE: While resolving: @eslint/js@10.0.1 Found: eslint@9.39.4 Could not resolve dependency: peerOptional eslint "^10.0.0" from @eslint/js@10.0.1 This unblocks the Dependabot PR by aligning eslint to ^10.0.0 (resolves to 10.6.0). Verified locally against the exact CI gates: - npm ci ................ exit 0, 0 vulnerabilities - npx eslint . .......... exit 0 (warnings only, no errors) - npm test (vitest) ..... 85/85 passed - npm run build ......... success (343ms) Note: eslint 10 is a major bump. The lint run against the new engine produces only warnings (no errors) — the same react-hooks advisory warnings already present under eslint 9, plus a new `react-hooks/set-state-in-effect` advisory from the v7 plugin. No source changes were needed; eslint.config.js already targets the v9+ flat config and is compatible with v10. Relates to: PR #75, run 28824401910
ef86842 to
6d5840f
Compare
|
Closing as obsolete — the state this PR was trying to reach is already on master. This is one of ~49 stale draft PRs, most of them repeated attempts at the same few fixes (roughly 20 are variations of "pin click>=8.3.3"). Each CI failure appears to have opened a new PR rather than updating an existing one, so the backlog grew without ever converging. Verified before closing — every advisory these were chasing is resolved:
Nothing is lost by closing: the one piece of real engineering knowledge in this batch — that svix 2.0.0 changed Reopen if you disagree; nothing here was deleted. |
What
Fixes the CI failure on Dependabot PR #75 (
build(deps-dev): bump @eslint/js from 9.39.4 to 10.0.1) — GitHub Actions run #28824401910, jobFrontend audit + build, stepInstall dependencies.Root cause
Dependabot bumped
@eslint/jsto10.0.1but lefteslintpinned at^9.39.4.@eslint/js@10.0.1declarespeerOptional eslint: "^10.0.0", which conflicts witheslint@9.39.4, sonpm cifails with:This is a Dependabot-known limitation: it bumps one package at a time and doesn't account for the new peer dependency
@eslint/js@10added on its siblingeslint(see eslint/eslint#20467, which addedeslintto@eslint/js'speerDependenciesat the 10.0.0 release).Fix
Align
eslintto^10.0.0(resolves to10.6.0) so the peer constraint is satisfied. This supersedes / absorbs Dependabot PR #36 (build(deps-dev): bump eslint from 9.39.4 to 10.6.0) — both bumps end at the sameeslint@10.6.0.Verification (run in sandbox against this branch)
All four
Frontend audit + buildgates exercised locally:npm cinpx eslint .npm test(vitest)npm run buildLint produces no new errors under eslint 10. The warnings are the same
react-hooks/exhaustive-depsandreact-refresh/only-export-componentsadvisories already present under eslint 9, plus thereact-hooks/set-state-in-effectadvisory the v7 plugin already emits — all already demoted towarnineslint.config.js. No source changes were required; the flat config is compatible with both eslint 9 and 10.Notes for review
dependabot/npm_and_yarn/frontend/eslint/js-10.0.1(PR build(deps-dev): bump @eslint/js from 9.39.4 to 10.0.1 in /frontend #75's branch), notmaster. Merging this into build(deps-dev): bump @eslint/js from 9.39.4 to 10.0.1 in /frontend #75's branch lets Dependabot's PR go green; build(deps-dev): bump @eslint/js from 9.39.4 to 10.0.1 in /frontend #75 can then merge tomastercarrying both the@eslint/jsandeslintbumps together.master(it carries the@eslint/jsbump via the lockfile). Either path landseslint@10.6.0+@eslint/js@10.0.1.