Skip to content

Bump sysinfo, rusqlite, crossterm and indicatif - #35

Open
Sbussiso wants to merge 1 commit into
masterfrom
deps/rust-bumps
Open

Bump sysinfo, rusqlite, crossterm and indicatif#35
Sbussiso wants to merge 1 commit into
masterfrom
deps/rust-bumps

Conversation

@Sbussiso

Copy link
Copy Markdown
Contributor

Four of the five open Cargo bumps, taken together because they share no API
surface and one compile checks all of them.

crate from to Dependabot PR
sysinfo 0.30.13 0.39.6 #20
rusqlite 0.31.0 0.40.2 #28
crossterm 0.27.0 0.29.0 #24
indicatif 0.17.11 0.18.6 #23

No source changes were needed. The two that looked most likely to break
didn't, because this tree's usage is narrow: only System::host_name(),
Disks and sysinfo::Disk from sysinfo, and only params, Connection,
Row and Result from rusqlite. Nine and nine minor versions of churn
pass straight through that surface.

Verified locally, with the gates test.yml actually runs

gate result
cargo build --locked exit 0
cargo clippy --all-targets --locked exit 0, 30 warnings
cargo test --locked 241 passed, 0 failed, 1 ignored
cargo audit 1 allowed warning

The 30 clippy warnings are pre-existing doc/style lints in our own code
(doc list item overindented ×13, and similar). None references the bumped
crates and none is a deprecation notice from a new version.

A small win

indicatif 0.18 drops number_prefix, which clears one of the two
unmaintained advisories that test.yml's comment lists. fxhash remains
and is unchanged by this.

Why windows-service #25 is not in here

windows-service 0.8 only compiles under cfg(target_os = "windows").
test.yml runs ubuntu-only, so neither it nor src/service.rs is
compiled by any CI job — only by release.yml on a tag. I tried to verify
it locally and cargo check --target x86_64-pc-windows-msvc fails in
ring's build script with no MSVC toolchain available (and mingw isn't
installed).

Merging it here would ship an unverified change into the binary customers
install on their own hardware, which is exactly what this repo's
dependabot.yml says not to do. It needs a Windows CI leg first — filed
separately.

Closes #20
Closes #23
Closes #24
Closes #28

🤖 Generated with Claude Code

Four of the five open Cargo bumps, taken together because they share no
API surface and the compiler checks all of them at once:

  sysinfo    0.30.13 -> 0.39.6   (#20)
  rusqlite   0.31.0  -> 0.40.2   (#28)
  crossterm  0.27.0  -> 0.29.0   (#24)
  indicatif  0.17.11 -> 0.18.6   (#23)

No source changes were needed. The two that looked most likely to break
did not: this tree uses only `System::host_name()`, `Disks` and
`sysinfo::Disk` from sysinfo, and only `params`, `Connection`, `Row` and
`Result` from rusqlite — narrow enough that nine and nine minor
versions of churn pass straight through.

Verified locally with the same gates test.yml runs:

  cargo build --locked                  exit 0
  cargo clippy --all-targets --locked   exit 0, 30 warnings
  cargo test --locked                   241 passed, 0 failed, 1 ignored
  cargo audit                           1 allowed warning

The 30 clippy warnings are pre-existing doc and style lints in our own
code; none of them reference the bumped crates, and none is a
deprecation notice from the new versions.

indicatif 0.18 drops `number_prefix`, which clears one of the two
`unmaintained` advisories test.yml's comment lists. fxhash remains, and
is unchanged by this.

windows-service 0.8 (#25) is deliberately NOT here. It only compiles
under `cfg(target_os = "windows")`, test.yml runs ubuntu-only, and
cross-compiling to x86_64-pc-windows-msvc fails locally in ring's build
script with no MSVC toolchain available. Bumping it here would mean
shipping an unverified change into the binary customers install. It
needs a Windows CI leg first.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant