SONARJAVA-5975 S6856: FP when the ModelAttribute is a class#5515
Open
asya-vorobeva wants to merge 3 commits intomasterfrom
Open
SONARJAVA-5975 S6856: FP when the ModelAttribute is a class#5515asya-vorobeva wants to merge 3 commits intomasterfrom
asya-vorobeva wants to merge 3 commits intomasterfrom
Conversation
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
aurelien-coet-sonarsource
requested changes
Mar 6, 2026
...ult/src/main/java/checks/spring/s6856/MissingPathVariableAnnotationCheck_ModelAttribute.java
Show resolved
Hide resolved
|
aurelien-coet-sonarsource
approved these changes
Mar 6, 2026
Contributor
aurelien-coet-sonarsource
left a comment
aurelien-coet-sonarsource
left a comment
There was a problem hiding this comment.
LGTM !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See SONARJAVA-5975. Here I implement only the case when ModelAttribute is applied to mutable Data class. Record's case will be done in separated PR.