BUILD-10590 retrigger verified approvals on review events#87
Conversation
08bd1e1 to
c6f47bb
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new GitHub Actions workflow (.github/workflows/re-trigger-approvals.yml) that re-triggers the verified-approvals check whenever a pull request review is submitted or dismissed. This is part of the BUILD-10590 initiative to secure PRs via a GitHub org ruleset that requires the verified-approvals check to pass before merging. The workflow delegates to a reusable workflow in SonarSource/ci-github-actions.
Changes:
- Add
.github/workflows/re-trigger-approvals.ymlthat triggers onpull_request_review(submitted/dismissed) andworkflow_dispatch, and calls the reusablere-trigger-approvalsworkflow fromci-github-actions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
c6f47bb to
77f943a
Compare
SonarQube reviewer guide
|




Summary
Part of BUILD-10590 — PoC GitHub org rule workflow to secure PRs.
Adds a workflow that re-triggers the
verified-approvalscheck whenever a pull request review is submitted or dismissed.This ensures the approval count is re-evaluated after any review activity, keeping the GitHub ruleset check accurate.
Depends on SonarSource/ci-github-actions#227
Need to be merged first, for testing purposes. Then it will be realigned on master: #88
Changes
.github/workflows/re-trigger-approvals.yml: triggers onpull_request_review(submitted/dismissed) and delegates to the reusable workflowSonarSource/ci-github-actions/.github/workflows/re-trigger-approvals.yml.Context
The GitHub org ruleset #4485920 ("2 approvers for public repositories") requires the
verified-approvalsworkflow to pass before merging.This workflow enforces that:
This repository (
sonar-dummy-python-oss) is used as the test bed for the feature.Test plan
verified-approvalscheck is triggered on review submission