-
Notifications
You must be signed in to change notification settings - Fork 3
#171 Source Card Content #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SharonStrats
wants to merge
29
commits into
SolidOS:staging
Choose a base branch
from
SharonStrats:feat/card-content
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
82c7531
#171 modernize codebase
SharonStrats cac3f76
#171 First pass refactor to match new design
SharonStrats 09c552d
Brought over webcomponent from solid-ui
SharonStrats b704221
#171 basic web component
SharonStrats c3f4f53
fix babel config warnings
SharonStrats 89eeb04
#171 remove cancel button
SharonStrats d8fb855
#171 create and configure editor plus match design
SharonStrats 6514cf8
#171 add tests
SharonStrats 7c63181
Potential fix for pull request finding
SharonStrats e3adbf6
implement copilot suggestions
SharonStrats 5319223
Potential fix for pull request finding
SharonStrats 9370b86
copilot suggestions
SharonStrats 2b18c87
lazy load editor
SharonStrats 6842e6f
implement PR feedback
SharonStrats 11c03c6
Improve build tsc linting and babel
SharonStrats b228aa4
#171 add esm to make lazy loading work in mashlib
SharonStrats 6ecf3bd
minor styling updates
SharonStrats 446c89f
#171 show card only when editor is ready
SharonStrats 6911050
run cjs with testing
SharonStrats 09dc420
#171 add state similar to design-system in solid-ui
SharonStrats b08b03c
remove theme comment
SharonStrats 0b31d74
#171 theme changes
SharonStrats 3c2ad8a
#171 implement dirty and editing state
SharonStrats 4dc22f7
Potential fix for pull request finding
SharonStrats cd7e53d
cleanup code
SharonStrats c88ad04
Implement copilot suggestions for tests and package json
SharonStrats 13700d4
Update tsconfig.json
SharonStrats 96353b8
Update package.json
SharonStrats 10f860c
Update package.json
SharonStrats File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import path from 'path' | ||
|
|
||
| /** | ||
| * This file contains config options for babel using Lit decorators. | ||
| * | ||
| * @see https://lit.dev/docs/components/decorators/#using-decorators-with-babel | ||
| */ | ||
|
|
||
| const pathsUsingDecorators = ['src/design-system', 'src/primitives', 'src/storybook', 'src/components'] | ||
|
|
||
| export const litDecoratorsBabelOptions = { | ||
| assumptions: { | ||
| setPublicClassFields: true, | ||
| privateFieldsAsSymbols: true | ||
| }, | ||
| plugins: [ | ||
| '@babel/plugin-transform-class-static-block', | ||
| ['@babel/plugin-transform-typescript', { allowDeclareFields: true }], | ||
| ['@babel/plugin-proposal-decorators', { version: '2023-05' }], | ||
| '@babel/plugin-transform-class-properties' | ||
| ] | ||
| } | ||
|
|
||
| export const litDecoratorsLoaderOptions = { | ||
| cacheDirectory: true, | ||
| ...litDecoratorsBabelOptions, | ||
| } | ||
|
|
||
| export function resolvePathsUsingDecorators (projectRoot) { | ||
| return pathsUsingDecorators.map((_path) => path.resolve(projectRoot, _path)) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import PostCSS from 'postcss' | ||
| import TailwindCSS from '@tailwindcss/postcss' | ||
|
|
||
| const cssProcessor = PostCSS([TailwindCSS()]) | ||
|
|
||
| export default { | ||
| async transform (css, { filePath }) { | ||
| const result = await cssProcessor.process(css, { from: filePath }) | ||
|
|
||
| return result.css | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| declare module '*.styles.css' { | ||
| import type { CSSResultGroup } from 'lit' | ||
| const styles: CSSResultGroup | ||
| export default styles | ||
| } | ||
|
|
||
| declare module '*.css'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,67 @@ | ||
| import globals from 'globals' | ||
| import tsParser from '@typescript-eslint/parser' | ||
| import tsPlugin from '@typescript-eslint/eslint-plugin' | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd rather you do not chnage the structure of this file. I aligned all eslint configs accross all repos. Would rather keep is as similar as possible. Adding ts is ok of course solid-logic has it for example. You can copy from there. |
||
|
|
||
| const commonGlobals = { | ||
| ...globals.browser, | ||
| ...globals.node, | ||
| Atomics: 'readonly', | ||
| SharedArrayBuffer: 'readonly', | ||
| } | ||
|
|
||
| const commonRules = { | ||
| semi: ['error', 'never'], | ||
| quotes: ['error', 'single'], | ||
| 'no-console': 'warn', | ||
| 'prefer-const': 'error', | ||
| 'no-var': 'error', | ||
| } | ||
|
|
||
| export default [ | ||
| { | ||
| ignores: [ | ||
| 'node_modules/**', | ||
| 'coverage/**' | ||
| 'coverage/**', | ||
| 'lib/**' | ||
| ], | ||
| }, | ||
| { | ||
| files: ['src/**/*.js'], | ||
| languageOptions: { | ||
| globals: { | ||
| ...globals.browser, | ||
| ...globals.node, | ||
| Atomics: 'readonly', | ||
| SharedArrayBuffer: 'readonly', | ||
| ...commonGlobals, | ||
| }, | ||
| }, | ||
|
|
||
| rules: { | ||
| // Code style - match TypeScript settings | ||
| semi: ['error', 'never'], | ||
| quotes: ['error', 'single'], | ||
|
|
||
| // Strict checking - match TypeScript strictness | ||
| 'no-console': 'warn', | ||
| 'no-unused-vars': 'warn', // Match TypeScript noUnusedLocals: true | ||
| ...commonRules, | ||
| 'no-unused-vars': 'warn', | ||
| 'no-undef': 'error', | ||
| strict: ['error', 'global'], // Match TypeScript alwaysStrict: true | ||
|
|
||
| // Additional strictness to match TypeScript behavior | ||
| strict: ['error', 'global'], | ||
| 'no-implicit-globals': 'error', | ||
| 'prefer-const': 'error', // Encourage immutability | ||
| 'no-var': 'error', // Use let/const only | ||
| 'no-redeclare': 'error' | ||
| } | ||
| }, | ||
| { | ||
| files: ['src/**/*.ts', '**/*.d.ts'], | ||
| languageOptions: { | ||
| parser: tsParser, | ||
| parserOptions: { | ||
| sourceType: 'module', | ||
| }, | ||
| globals: { | ||
| ...commonGlobals, | ||
| }, | ||
| }, | ||
| plugins: { | ||
| '@typescript-eslint': tsPlugin, | ||
| }, | ||
| rules: { | ||
| ...commonRules, | ||
| 'no-unused-vars': 'off', | ||
| 'no-undef': 'off', | ||
| 'no-redeclare': 'off', | ||
| '@typescript-eslint/no-unused-vars': 'warn' | ||
| } | ||
| } | ||
| ] | ||
| ] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move back to testingsolidos