Skip to content

Refactor/styles separate css#135

Closed
SharonStrats wants to merge 36 commits intofeature/add-dev-envfrom
refactor/styles-separateCSS
Closed

Refactor/styles separate css#135
SharonStrats wants to merge 36 commits intofeature/add-dev-envfrom
refactor/styles-separateCSS

Conversation

@SharonStrats
Copy link
Copy Markdown
Contributor

@SharonStrats SharonStrats commented Mar 24, 2026

Ticket: SolidOS/solidos#244

Tested in solid-panes using local source-pane.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Source Pane to move UI styling out of inline JS into dedicated CSS, and introduces a Webpack-based build/dev setup so the package can ship compiled artifacts (with CSS handling) under lib/.

Changes:

  • Refactor src/sourcePane.js to ES module syntax, import CSS, and replace inline styling with CSS classes in src/styles/sourcePane.css.
  • Add Webpack configs (prod + dev) plus Babel config to build lib/source-pane(.min).js and support local dev via webpack-dev-server.
  • Update Jest setup with module mappers/mocks for CSS and solid-ui, and adjust tests/helpers for the new module format.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/sourcePane.js Switch to ESM, import CSS, and replace inline visibility/color styling with class toggles.
src/styles/sourcePane.css New stylesheet for Source Pane layout and state/visibility styling.
webpack.module.rules.mjs Centralize loader rules for JS/TS, CSS, CSS modules, and TTL assets.
webpack.config.mjs Production build to lib/ (UMD) with minified variant and styles copied to lib/styles.
webpack.dev.config.mjs Dev-server configuration for local development with HTML template and polyfills.
babel.config.mjs Babel preset config and TTL inline-import plugin configuration.
package.json Publish/build changes: output in lib/, build scripts, CSS sideEffects, dev server script, new devDependencies.
jest.config.mjs Update Jest module mapping for $rdf, solid-ui, and CSS imports.
test/sourcePane.test.js Adjust import pattern to handle default export interop and reorganize result variable scope.
test/helpers/setup.js Replace solid-logic store usage with an rdflib graph+Fetcher for tests.
test/helpers/solidUiMock.js Add a minimal solid-ui mock (icons/widgets/ns) for DOM tests.
test/helpers/styleMock.js Add CSS import mock for Jest.
test/helpers/rdfMock.js Add $rdf mapper target for Jest (re-export rdflib).
dev/index.js Add a local dev entry that loads a target URI and renders the pane.
dev/index.html Add HTML template for the dev server.
dev/dev-global.css Add local-only global CSS for dev UX.
dev/context.js Add a dev context helper using solid-logic store/singleton.
README.md Document AI-assisted refactor note.
.gitignore Ignore lib/ build output.
Comments suppressed due to low confidence (1)

test/sourcePane.test.js:12

  • result is now shared across the sibling text/turtle file and text/plain file describes. This can cause state leakage between suites (especially if additional tests are added later). Prefer scoping result inside each describe (or reinitializing it in each beforeEach) so each suite has its own isolated DOM.
  describe("test button compact", () => {
    let result


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread webpack.config.mjs Outdated
Comment thread README.md Outdated
SharonStrats and others added 5 commits March 24, 2026 14:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Bumps the npm_and_yarn group with 1 update in the / directory: [picomatch](https://github.com/micromatch/picomatch).


Updates `picomatch` from 2.3.1 to 2.3.2
- [Release notes](https://github.com/micromatch/picomatch/releases)
- [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md)
- [Commits](micromatch/picomatch@2.3.1...2.3.2)

---
updated-dependencies:
- dependency-name: picomatch
  dependency-version: 2.3.2
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
…yarn-66413a1f6e

Bump picomatch from 2.3.1 to 2.3.2 in the npm_and_yarn group across 1 directory
@SharonStrats SharonStrats self-assigned this Mar 28, 2026
@SharonStrats SharonStrats moved this to In review in SolidOS NLNet UI Mar 28, 2026
bourgeoa and others added 9 commits March 30, 2026 16:26
Add GitHub release step after npm publish
Implement GitHub release workflow
Fix syntax for version tag in CI workflow
Bumps [solid-ui](https://github.com/SolidOS/solid-ui) from 3.0.5 to 3.0.6.
- [Release notes](https://github.com/SolidOS/solid-ui/releases)
- [Commits](SolidOS/solid-ui@v3.0.5...v3.0.6)

---
updated-dependencies:
- dependency-name: solid-ui
  dependency-version: 3.0.6
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…-3.0.6

Bump solid-ui from 3.0.5 to 3.0.6
Bumps the npm_and_yarn group with 1 update in the / directory: [@xmldom/xmldom](https://github.com/xmldom/xmldom).


Updates `@xmldom/xmldom` from 0.8.11 to 0.8.12
- [Release notes](https://github.com/xmldom/xmldom/releases)
- [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md)
- [Commits](xmldom/xmldom@0.8.11...0.8.12)

---
updated-dependencies:
- dependency-name: "@xmldom/xmldom"
  dependency-version: 0.8.12
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
…yarn-282a1442c2

Bump @xmldom/xmldom from 0.8.11 to 0.8.12 in the npm_and_yarn group across 1 directory
Updated Node.js version in CI workflow from 22 to 20.
bourgeoa and others added 13 commits April 13, 2026 11:22
Change Node.js version to 20 in CI workflow
Bumps the npm_and_yarn group with 1 update in the / directory: [@xmldom/xmldom](https://github.com/xmldom/xmldom).


Updates `@xmldom/xmldom` from 0.8.12 to 0.8.13
- [Release notes](https://github.com/xmldom/xmldom/releases)
- [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md)
- [Commits](xmldom/xmldom@0.8.12...0.8.13)

---
updated-dependencies:
- dependency-name: "@xmldom/xmldom"
  dependency-version: 0.8.13
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <support@github.com>
…yarn-0a68a62365

Bump @xmldom/xmldom from 0.8.12 to 0.8.13 in the npm_and_yarn group across 1 directory
@SharonStrats
Copy link
Copy Markdown
Contributor Author

taken in milestone3m.

@github-project-automation github-project-automation Bot moved this from In review to Done in SolidOS NLNet UI Apr 24, 2026
@SharonStrats SharonStrats deleted the refactor/styles-separateCSS branch April 24, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants