Skip to content

Improve data content pane, accessibility, mobile and code - #803

Open
SharonStrats wants to merge 1 commit into
stagingfrom
feat/data-content
Open

SharonStrats wants to merge 1 commit into
stagingfrom
feat/data-content

Conversation

@SharonStrats

Copy link
Copy Markdown
Contributor

Improve data content pane, accessibility, mobile and code
Examples: use debug instead of console, solid-ui variables instead of mashlib, px for padding/margin...
mobile wrapping and font.

various accessibility fixes.

  • Added semantic table structure for RDF data with row headers using .
  • Added unique IDs and headers associations between predicate headers and value cells.
  • Added accessible aria-label="Properties" labels to nested property tables.
  • Added an accessible label for embedded XML/HTML content: role="group" with aria-label="Embedded HTML content".
  • Added descriptive aria-label text for referenced blank-node links.
  • Preserved native browser behavior for modified link clicks such as Ctrl/Cmd-click and Shift-click.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Duplicate header IDs undermine assistive-technology associations, while unwrapped subject links and non-stacking predicate headers break narrow-pane layouts.

3 open issues
What changed in this PR

This PR improves the RDF data content pane’s accessibility and responsive presentation, with supporting tests and a small dialog compatibility change.

Changes:

  • Adds semantic headers, language metadata, accessible labels, and ordered collections.
  • Updates mobile and nested-formula styling and preserves native modified-link clicks.
  • Adds rendering tests and replaces Array.at(-1) in dialog focus handling.
File Description
test/​unit/​paneLayout.test.ts Updates spacing assertions for the revised CSS.
test/​unit/​dataContentPane.test.ts Tests semantic rendering, sanitization, nested formulas, and link behavior.
src/​dataContentPane.ts Adds accessibility metadata and safer link handling; simplifies imports and logging.
src/​dataContentPane.css Revises responsive layouts, wrapping, spacing, and colors.
src/​components/​resource-action-dialog/​ResourceActionDialog.ts Uses array indexing for backward focus wrapping.

Review effort: Balanced

Comment thread src/dataContentPane.css Resolved
Comment thread src/dataContentPane.css Resolved
Comment thread src/dataContentPane.ts Resolved
Prompt: Make nested formula responsive on desktop

Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

Data Content Pane: Freshen up code and mobile Data content pane: accessibility

2 participants