Repository navigation
Improve data content pane, accessibility, mobile and code - #803
Open
SharonStrats wants to merge 1 commit into
Open
SharonStrats wants to merge 1 commit into
SharonStrats wants to merge 1 commit into
Conversation
This was
linked to
issues
Nov 7, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Duplicate header IDs undermine assistive-technology associations, while unwrapped subject links and non-stacking predicate headers break narrow-pane layouts.
3 open issues
What changed in this PR
This PR improves the RDF data content pane’s accessibility and responsive presentation, with supporting tests and a small dialog compatibility change.
Changes:
- Adds semantic headers, language metadata, accessible labels, and ordered collections.
- Updates mobile and nested-formula styling and preserves native modified-link clicks.
- Adds rendering tests and replaces
Array.at(-1)in dialog focus handling.
| File | Description |
|---|---|
test/unit/paneLayout.test.ts |
Updates spacing assertions for the revised CSS. |
test/unit/dataContentPane.test.ts |
Tests semantic rendering, sanitization, nested formulas, and link behavior. |
src/dataContentPane.ts |
Adds accessibility metadata and safer link handling; simplifies imports and logging. |
src/dataContentPane.css |
Revises responsive layouts, wrapping, spacing, and colors. |
src/components/resource-action-dialog/ResourceActionDialog.ts |
Uses array indexing for backward focus wrapping. |
Review effort: Balanced
Prompt: Make nested formula responsive on desktop Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
SharonStrats
force-pushed
the
feat/data-content
branch
from
November 7, 2026 21:10
cf89e74 to
9d0a1d5
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Improve data content pane, accessibility, mobile and code
Examples: use debug instead of console, solid-ui variables instead of mashlib, px for padding/margin...
mobile wrapping and font.
various accessibility fixes.