Repository navigation
delete it was not working in new design, also use new dialog - #799
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The deletion handler lacks behavioral test coverage, and the enabled delete button allows overlapping requests that can produce conflicting success and failure dialogs.
2 open issues
What changed in this PR
This PR updates resource deletion in the internal pane, replaces native prompts with a reusable dialog, and fixes display-only RDF statements leaking into the live store.
Changes:
- Delegate deletion to shared resource logic and emit a deletion event on success.
- Add confirmation and informational dialogs with keyboard focus handling.
- Copy statements before adding display metadata, with regression tests for store integrity and dialog behavior.
| File | Description |
|---|---|
test/unit/internalPane.test.ts |
Tests store integrity and document unloading after rendering. |
test/unit/components/resourceActionDialog.test.ts |
Tests dialog cancellation, focus restoration, and keyboard navigation. |
src/internal/internalPane.ts |
Updates deletion and messaging; isolates display-only statements. |
src/components/resource-action-dialog/ResourceActionDialog.ts |
Adds a reusable confirmation and informational dialog. |
src/components/resource-action-dialog/ResourceActionDialog.styles.css |
Styles dialog layout, text wrapping, and focus indicators. |
Review effort: Balanced
Prompt: Use deleteRecursive from solid-logic, create a resource action dialog and use the solid-ui-dialog, use this in internal pane for confirmation and for messaging. Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
SharonStrats
force-pushed
the
fix/internal-delete
branch
2 times, most recently
from
November 7, 2026 04:34
0e2f86d to
19a38d9
Compare
This was
linked to
issues
Nov 7, 2026
SharonStrats
force-pushed
the
fix/internal-delete
branch
from
November 7, 2026 11:59
832d320 to
7b7cd38
Compare
…@5.0.2-8 pane-registry@5.0.2-3 folder-pane@4.0.1-2 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
SharonStrats
changed the title
SharonStrats
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new design was not responding to delete. it appeared as if it wasn't deleted. Took the opportunity to use the recursive delete function from solid-logic and freshen up the messaging to use the new dialog.
Even though we might not keep the pane.