Repository navigation
fix recursive delete - #356
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the cross-graph containment cleanup change in recursive deletion.
No open issues 🎉
What changed in this PR
This PR addresses recursive deletion failures in the internal pane by removing cached containment statements regardless of their source graph.
Changes:
- Removes the parent-document graph restriction from containment cleanup.
- Updates cleanup assertions and adds a regression test verifying that document cleanup errors propagate rather than report success.
| File | Description |
|---|---|
test/resourceLogic.test.ts |
Updates containment cleanup expectations and tests cleanup failure propagation. |
src/resource/resourceLogic.ts |
Removes matching containment statements across all graphs during recursive deletion. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use in internal pane and delete was not working.