Repository navigation
ci: fail a pull request that starts before the latest release - #22
Merged
Merged
Conversation
A pull request made from an old main undoes what was fixed since and conflicts (strata#60 started 32 commits back, before 0.7.0). The new `base` job checks out the branch as pushed, not the merge GitHub prepares, and fails when it does not include the latest v… tag of the base branch, with the commands to update it. A branch a few commits behind only gets a notice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ke7yEW5dhDYFVpV2cdgs87 Signed-off-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This is the same
basejob as in SolidGeeks/strata, added to the CI. It checks the branch as pushed, not the merge GitHub prepares (that merge always containsmain):v…tag of the base branch (todayv1.0.1). The error gives the commands to update it.main.Why: an old branch undoes what was fixed since, and conflicts. In Strata, PR #60 started 32 commits back, before a fix it touched. The README (License and contributing) explains the rule.
How to check it
The job's script, run locally:
v1.0.0: fails withThis branch starts before v1.0.1: it is 15 commits behind main…main:Up to date with main.On this PR the job should be green, since the branch starts from the current
main.To make the job block merging, add
baseto the required status checks ofmainin the settings.The Solid checklist
git commit -s, see DCO)Generated by Claude Code