EBP-3100: Remove PubSub+ branding from distributed tracing samples - #99
Draft
shaanchander-solace wants to merge 1 commit into
Draft
shaanchander-solace wants to merge 1 commit into
shaanchander-solace wants to merge 1 commit into
Conversation
Uses the official names from the Solace renamed-products page. Also points the connection-timeout comment at the current docs URL; the old PubSub-branded path redirects to the guide home.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes customer-visible "PubSub+" text from the distributed tracing samples, the ones that exercise
solace-opentelemetry-jcsmp-integration. Part of the JCSMP OTel integration rebrand (EBP-1132).Four lines in
features/distributedtracing/, comments and one printed string, no identifiers or copyable code:GuaranteedPublisherWithManualInstrumentation.java:51,GuaranteedPublisherWithCustomPropagation.java:54: "Solace PubSub+ Broker" to "Solace Event Broker"QueueSubscriberWithManualInstrumentation.java:114: "PubSub+ Manager WebGUI" to "Broker Manager WebGUI"QueueSubscriberWithManualInstrumentation.java:77: docs link moved from theSolace-PubSub-Messaging-APIspath, which now redirects to the guide home, toAPI/API-Developer-Guide/Configuring-Connection-T.htm, the same URLSimpleFlowToQueueNack.javausesNames follow https://docs.solace.com/Release-Notes/renamed-products.htm.
Scope is the tracing samples only. The same "PubSub+ Manager WebGUI" string remains in
patterns/GuaranteedProcessor.java:128andpatterns/GuaranteedSubscriber.java:107, the old docs URL remains in eight other files, andsemp-rest-api/curl-create-queue-with-subscription.txt:3still says "PubSub+ Manager GUI". 16 lines in 12 files, all general JCSMP content, left for a separate change so this PR stays tied to the OTel integration work. Happy to widen it here if you would rather take it all at once.Test plan: comment and string edits only; grep for
pubsub(case-insensitive) overfeatures/distributedtracing/andsnippets/HowToImplementTracingManualInstrumentation.javareturns nothing.