feat(new): Add ability to set the newProperties#1721
Open
ChristopheCVB wants to merge 6 commits intoSoftwareBrothers:masterfrom
Open
feat(new): Add ability to set the newProperties#1721ChristopheCVB wants to merge 6 commits intoSoftwareBrothers:masterfrom
ChristopheCVB wants to merge 6 commits intoSoftwareBrothers:masterfrom
Conversation
…he editProperties
dziraf
reviewed
Dec 6, 2024
| /> | ||
| )) | ||
| : resource.editProperties.map((property) => ( | ||
| : resource.newProperties.map((property) => ( |
Contributor
There was a problem hiding this comment.
We might also need to update where to new in BasePropertyComponent and LayoutElementRenderer. new would then also have to be added to i. e. isVisible for properties etc.
Author
There was a problem hiding this comment.
The where is used to determine the component to render in BasePropertyComponent and we actually want to render the property with the edit component
Author
|
@dziraf Any chance you have a look at this soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to set the
newPropertiesthe same way we set theeditProperties