Skip to content

fix(hooks): use strings for binary file scanning in pre-push#58

Merged
John-David Dalton (jdalton) merged 1 commit intomainfrom
fix/hooks-strings-binary-scanning
Apr 14, 2026
Merged

fix(hooks): use strings for binary file scanning in pre-push#58
John-David Dalton (jdalton) merged 1 commit intomainfrom
fix/hooks-strings-binary-scanning

Conversation

@jdalton
Copy link
Copy Markdown
Collaborator

Summary

  • Use strings command for binary files (WASM, .lockb, etc) instead of raw grep to properly detect embedded paths and secrets
  • Detect binary vs text using grep -qI, then extract printable strings before running pattern checks
  • Add -- to grep for private key pattern to prevent dash-prefixed patterns being parsed as options

Test plan

  • Verify pre-push hook passes on clean push
  • Verify hook catches hardcoded paths in binary files

@jdalton John-David Dalton (jdalton) merged commit 0396fda into main Apr 14, 2026
9 checks passed
@jdalton John-David Dalton (jdalton) deleted the fix/hooks-strings-binary-scanning branch April 14, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant