fix(package-env): improve Windows npm version detection#983
Merged
John-David Dalton (jdalton) merged 3 commits intov1.xfrom Dec 22, 2025
Merged
fix(package-env): improve Windows npm version detection#983John-David Dalton (jdalton) merged 3 commits intov1.xfrom
John-David Dalton (jdalton) merged 3 commits intov1.xfrom
Conversation
Bill Li (billxinli)
force-pushed
the
fix/windows
branch
from
b266e3f to
7094748
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Bill Li (billxinli)
force-pushed
the
fix/windows
branch
from
0b38102 to
db60bb9
Compare
Contributor
|
Cursor (@cursor) review |
John-David Dalton (jdalton)
approved these changes
Dec 22, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to fix a bug where Socket CLI fails to detect npm version (socket optimize blocked) on windows.
Windows 11 + Powershell
Windows 11 + cmd
OSX
Note
Strengthens npm version detection on Windows to handle shims and JS entrypoints reliably.
preferWindowsCmdShimto select.cmdshims and use when resolving npm pathresolveBinPathSyncingetAgentVersionto detect JS entrypoints (.js/.cjs/.mjs) and execute vianode; otherwise spawn directly withshell: WIN32getAgentExecPathfor npm to prefer.cmdnext tonode.exeand handle shim replacementtest/package-environment.npm-version.test.mtswith Vitest cases for JS entrypoint execution, fallback on resolution failure, and non-JS executablesWritten by Cursor Bugbot for commit d245ebd. Configure here.