chore: rename external-tools.json to bundle-tools.json#1190
Open
John-David Dalton (jdalton) wants to merge 4 commits intomainfrom
Open
chore: rename external-tools.json to bundle-tools.json#1190John-David Dalton (jdalton) wants to merge 4 commits intomainfrom
John-David Dalton (jdalton) wants to merge 4 commits intomainfrom
Conversation
* fix: migrate getSupportedScanFiles to getSupportedFiles (SDK v4) SDK v4 removed deprecated getSupportedScanFiles(). The replacement getSupportedFiles(orgSlug) requires an org parameter. Updated all type references from getReportSupportedFiles to getSupportedFiles. * fix(tests): update supported files tests for SDK v4 getSupportedFiles(orgSlug) * fix(tests): correct mock path for fetch-default-org-slug (.mjs not .mts) * fix: pass orgSlug to fetchSupportedScanFileNames instead of discovering internally
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
Revised schema proposal (addressing review feedback)The initial proposal had 3 blocking issues. Here's the updated design: Problem 1:
|
| Property | Purpose | When used |
|---|---|---|
description |
What it is | Always |
version |
Version string | Always |
repository |
owner/repo (GitHub default) or host:owner/repo |
GitHub sources |
release |
"asset" or "archive" |
With repository |
buildTag |
Extra tag for URL construction | When release URL needs it (python) |
packageManager |
"npm", "pip", "pnpm" |
Registry installs |
checksums |
SHA-256 per artifact | All downloads |
integrity |
SRI hash | npm packages |
npm |
Secondary npm source {package, version} |
Dual-source tools (sfw) |
notes |
Human notes | Optional |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
external-tools.json→bundle-tools.jsonto clarify its purpose as a VFS bundling manifest (npm packages, GitHub releases, PyPI packages with checksums)external-tools.jsonused by build-infra in sibling repos (socket-btm, ultrathink) which is a build tool configTest plan
Note
Low Risk
Low risk rename-only change, but any missed reference to
external-tools.jsonwill break SEA build/test setup by failing to load tool versions/checksums (e.g.,.env.testcomments still mention the old name).Overview
Renames the CLI bundling manifest to
bundle-tools.jsonand updates SEA download/bundling scripts, checksum sync tooling, test setup, and env/version/checksum error messaging to read from the new filename.This is primarily a wiring/docs update: all places that load tool versions/checksums for inlining and integrity verification now point at
bundle-tools.jsoninstead ofexternal-tools.json.Reviewed by Cursor Bugbot for commit ee16d6d. Configure here.