Info page #27
Open
Info page #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
io-design
reviewed
Aug 7, 2018
client/pages/Info/Info.jsx
Outdated
| import './Info.scss'; | ||
| import slack from '../../../public/images/slack.svg'; | ||
| import facebook from '../../../public/images/facebook.svg'; | ||
| import github from '../../../public/images/github-logo.svg'; |
io-design
reviewed
Aug 7, 2018
| @@ -1,33 +1,42 @@ | |||
| import React from 'react'; | |||
| import { InfoMap } from '../../components/InfoMap/InfoMap'; | |||
There was a problem hiding this comment.
Not sure what is the problem but map will work properly if you import it with other name (e.g. InfoMap2) and without curly braces
There was a problem hiding this comment.
@io-design without {} it will import GoogleApiWrapper since it's exported by default This is why you need to select different name.
io-design
reviewed
Aug 7, 2018
client/pages/Info/Info.jsx
Outdated
| <div className="map"> | ||
| { | ||
| <InfoMap /> | ||
| } |
io-design
reviewed
Aug 7, 2018
client/pages/Info/Info.scss
Outdated
| position: relative !important; | ||
| height: 100% !important; | ||
| width: 100% !important; | ||
| border: 1px solid black; |
There was a problem hiding this comment.
This border style will ruin map styles.
python4g
reviewed
Aug 8, 2018
| render() { | ||
| const { google } = this.props; | ||
| return ( | ||
| <Map google={google} zoom={14}> |
python4g
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge with dev without issues, map is loaded only sometimes
http://skrinshoter.ru/s/060818/9TQQa3ry?a screenshot