Dev #16
Open
Dev #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denald
reviewed
Oct 24, 2018
.gitignore
Outdated
| *.mo | ||
| *.pot | ||
|
|
||
| # Django stuff: |
There was a problem hiding this comment.
We don't use Django, I guess we can remove it from here
denald
reviewed
Oct 24, 2018
.gitignore
Outdated
| local_settings.py | ||
| db.sqlite3 | ||
|
|
||
| # Flask stuff: |
.gitignore
Outdated
| /site | ||
|
|
||
| # mypy | ||
| .mypy_cache/ No newline at end of file |
There was a problem hiding this comment.
Consider cleaning up this file from unnecessary stuff
README.md
Outdated
| Run `pip install pycodestyle` to perform project code inspection using `pep8`. | ||
|
|
||
| ## Run tests | ||
| - To run unit tests execute `python unit.py`. |
There was a problem hiding this comment.
We will use nose as test runner, the command should be different
README.md
Outdated
| ### Prerequisites | ||
| - Python [3.4 or higher](https://www.python.org/downloads/) | ||
| - Virtual environment [Virtualenvwrapper](https://virtualenvwrapper.readthedocs.io/en/latest/) | ||
| - Cloned repository [git](git@github.com:repo/repo.git) |
README.md
Outdated
| - Docker-compose [install](https://docs.docker.com/compose/install/) | ||
|
|
||
| ### Setting up the project | ||
| - create new virtual env `mkvirtualenv -p <path/to/python3> project_name`, |
There was a problem hiding this comment.
Maybe it's better to name virtual env to something like api-tests
README.md
Outdated
| - activate the env by running `workon project_name` | ||
| - Install modules `pip install -r ~/<path to project>/requirements.pip` | ||
| - Clone repository [rest_Spring_Docker](https://github.com/momel/rest_Spring_Docker) | ||
| - Up clone image: `cd ~/<path to your cloned repository>` and `docker-compose up -d` |
There was a problem hiding this comment.
It's not clear what we actually doing with this command, consider changing wording
__init__.py
Outdated
| raise RuntimeError('Test error!') | ||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
We will run our tests with nose test runner, please remove these lines of code from here
__init__.py
Outdated
| @@ -0,0 +1,20 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
This file should be moved to functional folder
JonnyJoypad
reviewed
Oct 24, 2018
.gitignore
Outdated
| *$py.class | ||
|
|
||
| # C extensions | ||
| *.so |
There was a problem hiding this comment.
Unnecessary stuff for us now: C# or Shared objects (.so)
fix imports in unit/__init__.py and functional/__init__.py move __init__.py from root to tests cleaned up file .gitignore fixed link, virtualenv instruction, docker instruction, running instruction and added new lib on git on file readme.md add version for modules in requirements.pip
Author
|
changed name class UserConstants to DefaultUser and add new clases BaseUrl, Endpoints in file constants.py changed functionality in file functional/__init__.py added new file tests_login.py in functional added new python package utils with files __init__ and helper.py empty tests/__init__.py change nose run instruction
Add new function at init file for test cool down time changes.
remove tests_login.py to the new branch pycodestyle fix in helper.py add configuration file .pylintrc ad pylint in requirements.pip
…eparate user and admin. In my tests I need login like user and like admin, and I think that it is best way. ATTENTION! You will need refactor your code, because now DefaultUser.user != admin. Add new function to get current cool down time. End write tests for /cooldowntime
- Add new functions to get/set token life time. - Add new function to get reset. other: - Add new tests for cool down time (positive, negative, boundary) - Add new file with all tests for token life - refactoring my own files
- Add new functions to get all users. - Change names of my own params, that must be understandable other: - Add new file with all tests for /users - refactoring my own files
…ssion and reset API and python3 style code fix add new file tests_admins for testing API /admin add new file login for testing API /login add new file logout for testing API /logout
fixed merge conflicts
Tests of locking users and smth else
…ith __init__ method
Heneralchuk, user tests
…, for example look file tests_login. It is the new architecture, when logic exists separately tests
replace the api functions from functional/__init__.py to the new file application/application.py
Implement ApiWrapper
refactoring code for new architecture
Application changes in tests
…RestPyTAC into doc_staff # Conflicts: # tests/functional/tests_locked.py
add tests for login, logout, admins with empty token
docstring fixes
ohrytsiuk->dev
refactoring docstrings
doc-strings in tests_cooldowntime and tests_locked updated
edited doc strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement project sceleton