ansible: pin ANSIBLE_CONFIG to disable ambient config discovery - #643
Open
sfc-gh-ikryvanos wants to merge 1 commit into
Open
ansible: pin ANSIBLE_CONFIG to disable ambient config discovery#643sfc-gh-ikryvanos wants to merge 1 commit into
sfc-gh-ikryvanos wants to merge 1 commit into
Conversation
ansible-playbook auto-discovers a configuration file from the current working directory (./ansible.cfg) or the home directory (~/.ansible.cfg). Because the server runs privileged and its working directory is not guaranteed to be trusted, a caller able to drop a file in those locations could supply a config that points plugin/library/roles paths at attacker-controlled code and gain execution on the next run. Pin ANSIBLE_CONFIG via a new bindable AnsibleConfigFile variable defaulting to os.DevNull, which loads an empty config and disables that discovery. Operators can set it to a trusted path to supply a real configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ansible-playbook auto-discovers a configuration file from the current working directory (./ansible.cfg) or the home directory (~/.ansible.cfg). Because the server runs privileged and its working directory is not guaranteed to be trusted, a caller able to drop a file in those locations could supply a config that points plugin/library/roles paths at attacker-controlled code and gain execution on the next run.
Pin ANSIBLE_CONFIG via a new bindable AnsibleConfigFile variable defaulting to os.DevNull, which loads an empty config and disables that discovery. Operators can set it to a trusted path to supply a real configuration.