sysinfo: stop silently truncating oversized journal entries - #640
Open
sfc-gh-ikryvanos wants to merge 1 commit into
Open
sysinfo: stop silently truncating oversized journal entries#640sfc-gh-ikryvanos wants to merge 1 commit into
sfc-gh-ikryvanos wants to merge 1 commit into
Conversation
bufio.Scanner's 64 KiB token cap made Scan stop on an oversized journal entry (bufio.ErrTooLong was never surfaced), silently dropping the remainder of the stream and enabling audit evasion. Read whole lines with no fixed cap, emit an explicit truncation marker when a single entry exceeds the per-entry limit, and fail loud on read errors instead of stopping silently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bufio.Scanner's 64 KiB token cap made Scan stop on an oversized journal entry (bufio.ErrTooLong was never surfaced), silently dropping the remainder of the stream and enabling audit evasion. Read whole lines with no fixed cap, emit an explicit truncation marker when a single entry exceeds the per-entry limit, and fail loud on read errors instead of stopping silently.