Harden MPA approver dedup and action IDs - #635
Open
sfc-gh-ikryvanos wants to merge 1 commit into
Open
Conversation
sfc-gh-ikryvanos
commented
Aug 13, 2026
sfc-gh-ikryvanos
commented
Collaborator
- Compare approver groups as an order-independent set so the same principal cannot be recorded as multiple approvers by reordering their groups (previously an order-sensitive reflect.DeepEqual).
- Use the full 256-bit SHA-256 digest for action IDs instead of a truncated 96-bit prefix, and bind Store/Approve to the exact action content (proto.Equal) so a hash collision cannot let an approval apply to a different action. Existing IDs remain a prefix of the new ones.
- Compare approver groups as an order-independent set so the same principal cannot be recorded as multiple approvers by reordering their groups (previously an order-sensitive reflect.DeepEqual). - Use the full 256-bit SHA-256 digest for action IDs instead of a truncated 96-bit prefix, and bind Store/Approve to the exact action content (proto.Equal) so a hash collision cannot let an approval apply to a different action. Existing IDs remain a prefix of the new ones. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.