fix(mpa): bound size of stored approval payloads - #633
Merged
Conversation
Store kept up to a fixed number of approval entries but placed no limit on the caller-controlled Any payload in each one, so a caller could pin a large amount of heap in the root server. Reject requests whose encoded size exceeds a per-request cap, track total stored bytes, and evict oldest entries to stay within a total budget. The two limits are exported package vars (MaxMessageBytes, MaxTotalBytes) and bound to the sansshell-server flags --mpa-max-message-bytes and --mpa-max-total-bytes, following the existing configuration convention. A value <= 0 disables the corresponding check. Adds regression tests for both bounds, byte accounting, and configurability. Co-authored-by: Cursor <cursoragent@cursor.com>
sfc-gh-mjankowski
approved these changes
Aug 10, 2026
sfc-gh-ikryvanos
enabled auto-merge (squash)
August 27, 2026 09:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store kept up to a fixed number of approval entries but placed no limit on the caller-controlled Any payload in each one, so a caller could pin a large amount of heap in the root server. Reject requests whose encoded size exceeds a per-request cap, track total stored bytes, and evict oldest entries to stay within a total budget.
The two limits are exported package vars (MaxMessageBytes, MaxTotalBytes) and bound to the sansshell-server flags --mpa-max-message-bytes and --mpa-max-total-bytes, following the existing configuration convention. A value <= 0 disables the corresponding check. Adds regression tests for both bounds, byte accounting, and configurability.