fix(localfile): reject symlinks in SetFileAttributes - #627
Merged
Conversation
Attribute changes followed symlinks, so chown/chmod/immutable could escape path-based policy confinement. Lstat-reject symlinks, use Lchown, and open immutable updates with O_NOFOLLOW. Co-authored-by: Cursor <cursoragent@cursor.com>
sfc-gh-mjankowski
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%23%23 Summary
SetFileAttributeson symlink paths (FailedPrecondition) so attribute changes cannot follow a link to an out-of-policy targetLchowninstead ofChown, and open immutable flag updates withO_NOFOLLOWon Linux as defense in depth%23%23 Test plan
go test ./services/localfile/server/...GOOS=linux GOARCH=amd64 go build ./services/localfile/...