Add review-skill-sflabs skill + CONTRIBUTING update

[jdanielmyers]

Summary

Adds the review-skill-sflabs skill — a pre-PR self-check that contributors run on their local skill directory to find out whether it would be a fit for this catalog before opening a pull request. Also updates CONTRIBUTING.md to recommend running it.

The skill applies safe mechanical fixes in place (with the contributor's confirmation) and flags content rewrites for manual revision. It produces an advisory verdict (promote / adapt / skip) plus a concrete checklist of issues. It does not gate PR acceptance — final review is human-in-the-loop.

Architecture

Router skill with 4 sub-workflows + 3 reference files:

skills/review-skill-sflabs/
  SKILL.md                          # Router. 5-phase workflow.
  LICENSE                           # Snowflake Skills License (employee author)
  workflows/
    format-check.md                 # Frontmatter, file structure, LICENSE, name, length limits
    duplicate-search.md             # web_search for verbatim/near-verbatim public copies
    data-policy-scan.md             # PII fields, tone/severity, disclaimer, hardcoded specifics
    catalog-fit.md                  # Bundled-skill overlap (disk + docs) + scope flexibility
  references/
    data-policy-principles.md       # Generic distilled principles (no internal terminology)
    mechanical-fix-rules.md         # Authoritative auto-fix vs flag table
    report-template.md              # Markdown shape of the final report

Design highlights

• No closed catalogs. Upstream skill detection is via web_search against distinctive phrases, not a hardcoded list. Bundled-skill overlap pulls from on-disk Cortex Code installs + the public docs page, never a static snapshot.
• Mechanical-only auto-fix. The skill only auto-applies changes when there is exactly one correct value (folder-name match, default language: en, default status: Published, missing LICENSE for community contributions). Anything that requires choosing between alternatives, or that touches body content, is flagged for the contributor — they stay in control of their writing.
• Generic data-policy principles. The principles file ships no Snowflake-internal terminology — it covers PII handling, advisory tone, color discipline, disclaimers, and scope flexibility as universal engineering guidance.
• Eats its own dogfood. The skill itself passes the same checks it enforces.

Audit pipeline status

audit run-tier labs --client mock against the merged branch:

• Verdict: Keep (one of only 2 Keep verdicts among 13 Labs skills)
• Blocking failures: 0
• Advisory failures: 1 — tdd.body.word_budget (router skill is over the 500-word default for technique class; reference-class budget would be 1500 which it satisfies). Documented as a known classification edge case for router skills.

Smoke-test results

5 fixtures in audit/tests/fixtures/review-skill-sflabs/ — each verified by walking through the skill workflow manually:

Fixture	Expected verdict	Actual
clean/	🟢 promote	✅
needs-fixes/	🟡 adapt (3 mechanical fixes + 1 manual)	✅
public-clone/	🟡 adapt (with adapted-from disclosure)	✅
bundled-collision/ (name=iceberg)	🟠 skip	✅
policy-violations/ (PII, tone, hardcoded emails)	🟡 adapt (multiple findings)	✅

Full results: audit/tests/fixtures/review-skill-sflabs/SMOKE-TEST-RESULTS.md (kept in the audit repo, not promoted to Labs).

Test plan

• Reviewer verifies frontmatter renders in the skill catalog
• /skill add from this branch loads the skill and all 4 workflow + 3 reference files cleanly
• $review-skill-sflabs <path> against a known-clean skill produces a 🟢 promote verdict
• $review-skill-sflabs <path> against a skill with name: colliding with a bundled skill produces a 🟠 skip verdict
• CONTRIBUTING.md TOC and new section render correctly on GitHub

Files

Path	Lines	Notes
skills/review-skill-sflabs/SKILL.md	118	Router
skills/review-skill-sflabs/LICENSE	22	Snowflake Skills License
skills/review-skill-sflabs/workflows/format-check.md	157
skills/review-skill-sflabs/workflows/duplicate-search.md	117
skills/review-skill-sflabs/workflows/data-policy-scan.md	146
skills/review-skill-sflabs/workflows/catalog-fit.md	178
skills/review-skill-sflabs/references/data-policy-principles.md	106
skills/review-skill-sflabs/references/mechanical-fix-rules.md	43
skills/review-skill-sflabs/references/report-template.md	84
CONTRIBUTING.md	+18	New "Review your skill before submitting" section