Promote snowpark-connect from Snowflake-Solutions#27
Draft
jdanielmyers wants to merge 1 commit into
Draft
Conversation
Member
Author
Audit Report: snowpark-connect
Summary
Critical 🔴None — all critical findings from the original audit have been addressed. Warnings 🟡None. Suggestions 🟢
VerdictReady to merge — Clean router with 5 well-named sub-flows, proper stopping point, and good routing logic. |
Re-staged with v1.1.1 holistic prompt that adds stopping-point markers, correct INSTRUCTIONS.md sub-flow cross-refs, and drops invalid tool snowflake_object_search. Note: removed rewriter-generated 'common mistakes' boilerplate line that triggered false-positive on <sub>/SKILL.md regex gate (was a negative example, not an actual cross-ref).
3d9fe47 to
c99382e
Compare
Collaborator
|
@jdanielmyers snowpark-connect is already an existing bundled skill, is there another reason you wanted to port this one over? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes the
snowpark-connectskill from the internalSnowflake-Solutions/cortex-code-skillsrepo to public Labs, rewritten for an external builder audience (developers, data engineers).Run through the v1.1.0 audit pipeline:
audience.no_internal_refscheck passes<sub>/INSTRUCTIONS.mdper the umbrella precedent (manage-zerocopy-sapbdc)Test plan
blocking_failures == 0audience.no_internal_refspassesSnowflake-Solutionsrepo path leakage