Skip to content

Promote snowpark-connect from Snowflake-Solutions#27

Draft
jdanielmyers wants to merge 1 commit into
mainfrom
promote/snowpark-connect
Draft

Promote snowpark-connect from Snowflake-Solutions#27
jdanielmyers wants to merge 1 commit into
mainfrom
promote/snowpark-connect

Conversation

@jdanielmyers
Copy link
Copy Markdown
Member

Summary

Promotes the snowpark-connect skill from the internal Snowflake-Solutions/cortex-code-skills repo to public Labs, rewritten for an external builder audience (developers, data engineers).

Run through the v1.1.0 audit pipeline:

  • Holistic LLM rewrite for builder audience
  • All internal Snowflake references substituted with public equivalents (e.g., Snowhouse -> ACCOUNT_USAGE)
  • audience.no_internal_refs check passes
  • Sub-skills folded into <sub>/INSTRUCTIONS.md per the umbrella precedent (manage-zerocopy-sapbdc)

Test plan

  • Audit blocking_failures == 0
  • audience.no_internal_refs passes
  • Frontmatter matches Labs conventions (snowflake-docs / manage-zerocopy-sapbdc precedents)
  • LICENSE present (Snowflake)
  • No Snowflake-Solutions repo path leakage
  • No nested SKILL.md in sub-skill dirs (all converted to INSTRUCTIONS.md)

@jdanielmyers
Copy link
Copy Markdown
Member Author

jdanielmyers commented May 20, 2026

Audit Report: snowpark-connect

Re-audit (post-v1.1.1 + critical fixes). Original report superseded.

Summary

Category 🔴 🟡 🟢
Frontmatter 0 0 0
Structure 0 0 0
Workflow 0 0 1

Critical 🔴

None — all critical findings from the original audit have been addressed.

Warnings 🟡

None.

Suggestions 🟢

  1. Textbook umbrella/router skill: thin (~80 lines), clear 5-option routing table, single stopping point before loading sub-flows, recommended ordering (Setup → Migrate → Validate → Optimize → Deploy), and concise "Common Mistakes" focused on process ordering rather than implementation details.

Verdict

Ready to merge — Clean router with 5 well-named sub-flows, proper stopping point, and good routing logic.

Re-staged with v1.1.1 holistic prompt that adds stopping-point markers,
correct INSTRUCTIONS.md sub-flow cross-refs, and drops invalid tool
snowflake_object_search.

Note: removed rewriter-generated 'common mistakes' boilerplate line that
triggered false-positive on <sub>/SKILL.md regex gate (was a negative example,
not an actual cross-ref).
@jdanielmyers jdanielmyers force-pushed the promote/snowpark-connect branch from 3d9fe47 to c99382e Compare May 20, 2026 21:18
@sfc-gh-kmuir
Copy link
Copy Markdown
Collaborator

@jdanielmyers snowpark-connect is already an existing bundled skill, is there another reason you wanted to port this one over?

@sfc-gh-kmuir sfc-gh-kmuir marked this pull request as draft May 22, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants