Skip to content

Promote dcr-v1-to-v2 from Snowflake-Solutions#25

Merged
jdanielmyers merged 1 commit into
mainfrom
promote/dcr-v1-to-v2
May 21, 2026
Merged

Promote dcr-v1-to-v2 from Snowflake-Solutions#25
jdanielmyers merged 1 commit into
mainfrom
promote/dcr-v1-to-v2

Conversation

@jdanielmyers
Copy link
Copy Markdown
Member

Summary

Promotes the dcr-v1-to-v2 skill from the internal Snowflake-Solutions/cortex-code-skills repo to public Labs, rewritten for an external builder audience (developers, data engineers).

Run through the v1.1.0 audit pipeline:

  • Holistic LLM rewrite for builder audience
  • All internal Snowflake references substituted with public equivalents (e.g., Snowhouse -> ACCOUNT_USAGE)
  • audience.no_internal_refs check passes

Test plan

  • Audit blocking_failures == 0
  • audience.no_internal_refs passes
  • Frontmatter matches Labs conventions (snowflake-docs / manage-zerocopy-sapbdc precedents)
  • LICENSE present (Snowflake)
  • No Snowflake-Solutions repo path leakage

@jdanielmyers
Copy link
Copy Markdown
Member Author

jdanielmyers commented May 20, 2026

Audit Report: dcr-v1-to-v2

Re-audit (post-v1.1.1 + critical fixes). Original report superseded.

Summary

Category 🔴 🟡 🟢
Frontmatter 0 0 0
Structure 0 1 0
Workflow 0 0 1

Critical 🔴

None — all critical findings from the original audit have been addressed.

Warnings 🟡

  1. Sub-flow generate/INSTRUCTIONS.md is 739 lines — significantly over the 500-line guideline. This sub-flow handles Collaboration API script generation and contains extensive SQL templates. → Consider splitting the SQL template blocks into a references/templates/ directory and keeping generate/INSTRUCTIONS.md as the workflow orchestrator.

Suggestions 🟢

  1. The router SKILL.md is well-structured with clear 6-step workflow, 4 stopping points, comprehensive "Common Mistakes" section (especially the two-call async teardown pattern and | join_policy filter removal).

Verdict

Ready to merge — Router is clean and well-structured. The 739-line sub-flow is a non-blocking concern (content is valid, just long). Merge and consider refactoring the sub-flow in a follow-up.

Re-staged with v1.1.1 holistic prompt that adds stopping-point markers,
correct INSTRUCTIONS.md sub-flow cross-refs, and drops invalid tool
snowflake_object_search.
@jdanielmyers jdanielmyers force-pushed the promote/dcr-v1-to-v2 branch from dd1a799 to d989c45 Compare May 20, 2026 21:15
@jdanielmyers jdanielmyers merged commit 919117b into main May 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant