fix(usePlaybackOptions): clear screen regions when screenRegions is unset#12
Open
andriiboliboksc wants to merge 5 commits into
Open
fix(usePlaybackOptions): clear screen regions when screenRegions is unset#12andriiboliboksc wants to merge 5 commits into
andriiboliboksc wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
screenRegionseffect bails on any falsy value, so passingundefinednever callssetScreenRegionsand previously-set regions can't be cleared via the prop.Drop the falsy guard and coalesce unset →
{}. SincesetScreenRegionsis full-replacement (empty object clears all regions), the hook is now properly declarative: pass regions to set them, omit/undefinedto clear.