Demonstrate bridge-function resolution teardown behavior in Hello World - #184
Open
clholgat wants to merge 2 commits into
Open
Demonstrate bridge-function resolution teardown behavior in Hello World#184clholgat wants to merge 2 commits into
clholgat wants to merge 2 commits into
Conversation
Add a debug-only teardown repro to the Hello World iOS app: an isolated runtime is torn down mid-resolution, then a probe bridge function is resolved through the raising +functionWithJSRuntime: path. Two buttons show both sides of the resolution-teardown degrade (VALDI_ENABLE_RESOLUTION_TEARDOWN_DEGRADE): degrade on returns a no-op (no crash), degrade off aborts (SIGABRT). Android/web wire the buttons to no-ops (iOS-specific).
📊 PR Size: size/LTotal changes: 390 lines (12 files) Top files changed:
...and 2 more files Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+) |
Third debug button (teardown-invocation-button): after teardown the resolution degrades to a no-op function, but INVOKING it returns a null value in a _Nonnull slot. Passing that null to a non-null-requiring API (+[NSURL fileURLWithPath:]) raises NSInvalidArgumentException and aborts (SIGABRT) — the invocation-teardown nil-in-nonnull crash, distinct from the resolution SIGABRT. Adds a string @ExportFunction (getTeardownPath) and an env-gated debug autorun hook (TEARDOWN_REPRO_AUTORUN=invocation) so it can be triggered without a tap.
🎉 Bazel & CI Test Results
All Bazel configuration and CI tests passed! ✨ The build system and core tooling are working correctly. 🚀 Bazel remote cache is now enabled - future builds will be faster! Workflow: Valdi CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a debug-only teardown repro to the Hello World iOS app: an isolated runtime is torn down mid-resolution, then a probe bridge function is resolved through the raising +functionWithJSRuntime: path. Two buttons show both sides of the resolution-teardown degrade (VALDI_ENABLE_RESOLUTION_TEARDOWN_DEGRADE): degrade on returns a no-op (no crash), degrade off aborts (SIGABRT).
Android/web wire the buttons to no-ops (iOS-specific).
Description
Type of Change
Testing
bazel test //...)Testing Details
Checklist
Related Issues
Additional Context