Skip to content

Add cross-platform debugger DevTools capabilities - #180

Closed
bjdodson-openai wants to merge 1 commit into
Snapchat:mainfrom
bjdodson-openai:bjd/debugger-capabilities
Closed

Add cross-platform debugger DevTools capabilities#180
bjdodson-openai wants to merge 1 commit into
Snapchat:mainfrom
bjdodson-openai:bjd/debugger-capabilities

Conversation

@bjdodson-openai

Copy link
Copy Markdown
Collaborator

Description

Collapses the reviewed post-foundation debugger stack into one dependency-complete commit atop current main.

This adds the cross-platform debugger capability set built across #155#175: explicit ports and authenticated sessions, input control, the legacy web bridge, integrated DevTools, runtime settings, bounded storage and performance inspection, generic and persistent-storage providers, Chromium console streaming, web tracing and performance capture, console clearing, target discovery and selection, component hierarchy/property inspection and editing, and bounded runtime-state inspection.

The aggregate preserves the fixes and discussion outcomes from the original stack, including lifecycle and authentication repairs. Synthetic Slack-shaped redaction fixtures are assembled at runtime so no complete token signature is stored in the commit.

This PR supersedes #155, #156, #157, #158, #159, #160, #161, #162, #163, #164, #165, #166, #167, #168, #169, #170, #171, #172, #173, #174, and #175. Those PRs retain the incremental review history.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation improvement
  • Performance optimization
  • Test improvement
  • Other (feature: cross-platform debugger capabilities)

Testing

  • Tests pass locally (bazel test //...)
  • Added/updated tests for changes (if applicable)
  • Tested on multiple platforms (iOS/Android/Web/macOS as applicable)
  • Manual testing performed (describe below)

Testing Details

  • CLI Jasmine suite: 450/450 passing
  • CLI production build: passing
  • bazel query //...: 9,700 targets resolved
  • Focused Bazel validation passed for runtime debugger, macOS Objective-C, and web renderer targets
  • git diff --check and complete-token scans: clean
  • Independent aggregate and post-redaction audits: clean

The full repository-wide bazel test //... matrix was not run locally; CI remains the final platform matrix.

Checklist

  • Code follows project style guidelines
  • Documentation updated (if needed)
  • No breaking changes (or documented in description)
  • Commit messages follow conventional format
  • No secrets, API keys, or internal URLs included

Related Issues

Relates to #154.

Supersedes #155#175 while preserving their review history.

Additional Context

The foundation from #154 landed through Snap's internal import as 17754a1d. This aggregate is one commit whose parent is the current upstream main commit and includes the reviewed post-foundation fixes omitted by that import.

@github-actions

github-actions Bot commented Aug 28, 2026

Copy link
Copy Markdown

⚠️ Bazel & CI Test Results

Test Suite Result
Snapshot Tests ✅ success
Linux: C++ Tests ❌ failure
API Surface Check ✅ success
Linux: Build Compiler ✅ success
Linux: Module Tests ✅ success
macOS: C++ & Platform Tests ✅ success
Valdi Smoke Tests ❌ failure
Linux: Hotreload Smoke ✅ success
Test Coverage Delta ✅ success
valdi_web Integration Test ✅ success
Linux: Registry Validation ✅ success
Linux: Build & Export ✅ success

Some tests failed. Please check the workflow logs for details.

🚀 Bazel remote cache is now enabled - future builds will be faster!

Workflow: Valdi CI

@bjdodson-openai
bjdodson-openai force-pushed the bjd/debugger-capabilities branch from 6ba3615 to 8678db4 Compare August 28, 2026 21:44
@clholgat
clholgat marked this pull request as ready for review August 28, 2026 21:51
@clholgat

Copy link
Copy Markdown
Collaborator

Thanks for pulling this together, @bjdodson-openai — the aggregate reads cleanly and the review history from #155#175 carries over well. We're importing this into our internal monorepo now to run it through the full platform test matrix for more testing. We'll follow up here with results. 🙏

Fold the post-foundation security and lifecycle review fixes into the cross-platform debugger capability landing.
@bjdodson-openai
bjdodson-openai force-pushed the bjd/debugger-capabilities branch from 8678db4 to 85a73ca Compare August 29, 2026 00:07
@clholgat clholgat closed this in 1c6ff75 Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build-system Bazel build rules and config area/docs Documentation area/runtime Valdi runtime (C++/native) platform/android Android-specific platform/ios iOS-specific

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants