Skip to content

Isolate web PersistentStoreNative memory by store name#113

Open
clholgat wants to merge 1 commit into
mainfrom
clholgat/web-persistent-store-isolation
Open

Isolate web PersistentStoreNative memory by store name#113
clholgat wants to merge 1 commit into
mainfrom
clholgat/web-persistent-store-isolation

Conversation

@clholgat

@clholgat clholgat commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Scope in-memory web persistence entries per store name instead of one shared map.
  • Keep TTL sweeping and newPersistentStore(...) behavior aligned with native store isolation expectations.

Test plan

  • Create two differently named web persistent stores; write the same key in each and confirm values do not collide
  • Call removeAll on one store and confirm the other store still has its entries
  • Confirm TTL expiry still removes entries via exists / fetch / setCurrentTime
  • Smoke existing web persistence/unit coverage if available

Made with Cursor

The previous single global map mixed keys across differently named stores,
so removeAll/fetchAll could cross-contaminate app preferences and other
persistence scopes on web.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions Bot added the size/M label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

📊 PR Size: size/M

Total changes: 141 lines (1 files)

Top files changed:

  • src/valdi_modules/src/valdi/persistence/web/PersistentStoreNative.ts: +87 -54

Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+)

@clholgat clholgat closed this Jul 8, 2026
@clholgat clholgat reopened this Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

⚠️ Bazel & CI Test Results

Test Suite Result
Snapshot Tests ✅ success
API Surface Check ✅ success
Linux: Build & Export ✅ success
Linux: Build Compiler ✅ success
Linux: C++ Tests ✅ success
Valdi Smoke Tests ❌ failure

Some tests failed. Please check the workflow logs for details.

🚀 Bazel remote cache is now enabled - future builds will be faster!

Workflow: Valdi CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant