Isolate web PersistentStoreNative memory by store name#113
Open
clholgat wants to merge 1 commit into
Open
Conversation
The previous single global map mixed keys across differently named stores, so removeAll/fetchAll could cross-contaminate app preferences and other persistence scopes on web. Co-authored-by: Cursor <cursoragent@cursor.com>
📊 PR Size: size/MTotal changes: 141 lines (1 files) Top files changed:
Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+) |
|
| Test Suite | Result |
|---|---|
| Snapshot Tests | ✅ success |
| API Surface Check | ✅ success |
| Linux: Build & Export | ✅ success |
| Linux: Build Compiler | ✅ success |
| Linux: C++ Tests | ✅ success |
| Valdi Smoke Tests | ❌ failure |
Some tests failed. Please check the workflow logs for details.
🚀 Bazel remote cache is now enabled - future builds will be faster!
Workflow: Valdi CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
newPersistentStore(...)behavior aligned with native store isolation expectations.Test plan
removeAllon one store and confirm the other store still has its entriesexists/fetch/setCurrentTimeMade with Cursor