Derive with_edge from edge feature presence (perf)#694
Draft
kmontemayor2-sc wants to merge 2 commits into
Draft
Conversation
… hardcoding True Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ph-store modes Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
Author
|
/all_test |
Contributor
GiGL Automation@ 00:38:38UTC : 🔄 @ 00:46:08UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 00:38:38UTC : 🔄 @ 02:13:17UTC : ❌ Workflow failed. |
Contributor
GiGL Automation@ 00:38:39UTC : 🔄 @ 00:40:22UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 00:38:41UTC : 🔄 @ 01:54:03UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 00:38:42UTC : 🔄 @ 00:48:27UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 00:38:42UTC : 🔄 @ 02:02:27UTC : ✅ Workflow completed successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
BaseDistLoader.create_sampling_confighardcodedwith_edge=Truefor everyloader. This derives it from whether the dataset actually has edge features:
DatasetSchema.edge_feature_infois already populated in both colocated andgraph-store modes (fetched from storage rank 0 in graph-store mode), so the
derivation is correct on compute nodes as well.
Why
For datasets with no edge features anywhere,
with_edge=Trueforces GLT tocollect sampled edge ids per hop and transport them in every
SampleMessage.Those eids are pure overhead when there are no edge features to gather: the
sampler writes an
int64eid tensor of one element per sampled edge (gated onself.with_edge). Withwith_edge=False, GLT takes thesamplepath insteadof
sample_with_edge,output.edgeisNone, no eids are collected orserialized, and edge-feature-store construction is skipped.
Behavior change (changelog)
Batches produced from featureless datasets no longer carry GLT's
data.edge(homogeneous) or
data[etype].edge(heterogeneous) sampled-edge-id attribute.A repo-wide grep found no consumer that reads this attribute off a produced
batch — the only in-repo references are the sampler's own write sites. External
code that reads
batch.edgeon a featureless dataset would now find itabsent/
None. Datasets that do have edge features are unaffected.Tests
create_sampling_config:with_edgeisFalsewhenedge_feature_infoisNone,Truefor homogeneous and heterogeneous edgefeatures.
edge ids (
data.edge is None).edge_feature_infois populated from thestorage cluster.
All affected files pass;
make type_checkpasses.