SMOODEV-2045: SDK self-emit is panic-proof (fix temporal-worker crashloop root cause)#67
Merged
Merged
Conversation
…igured-but-unreachable (fix worker crashloop root cause)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause of the prod temporal-worker crashloop (SMOODEV-1988 self-emit; mitigated by disabling it in SMOODEV-2031): the OTLP export executed in a context with no Tokio reactor present, so the HTTP request panicked; under the workspace's
panic = "abort"release profile that panic on the background path aborted the whole host process → crashloop (blocked eSign).Fix: drive the export on a dedicated
std::threadwith its own runtime so a missing-reactor / auth-401 / unreachable-endpoint never panics or aborts the host. The SDK is now genuinely best-effort even when configured-but-unreachable.Tests (new tests/self_emit_panic_safety.rs):
configured_but_unauthorized_ingest_does_not_panic,unreachable_endpoint_export_does_not_panic— both pass. fmt/clippy/test green.NOTE: this does NOT re-enable self-emit anywhere — SMOODEV-2031's
SMOOAI_OBSERVABILITY_DISABLEDstays. It makes the SDK safe so self-emit CAN be re-enabled after review.🤖 Generated with Claude Code