Skip to content

Matter Switch: Check feature bits of ColorControl during profiling #3251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hcarter-775 wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −0
Open

Matter Switch: Check feature bits of ColorControl during profiling #3251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21f5e3e
Check feature bits of ColorControl during profiling
hcarter-775 Sep 24, 2026
b150875
Add fingerprint for 5187/256 device
hcarter-775 Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions drivers/SmartThings/matter-switch/fingerprints.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,6 +577,12 @@ matterManufacturer:
vendorId: 0x1339
productId: 0x0055
deviceProfileName: plug-binary
#Goods iQ
- id: "5187/256" # Not WWST certified, exposes incorrect Device Type
deviceLabel: Cabinet Lights
vendorId: 0x1443
productId: 0x0100
deviceProfileName: light-color-level
#Govee
- id: "4999/24740"
deviceLabel: Govee Square Ceiling Light (12 inch)
Expand Down
10 changes: 10 additions & 0 deletions drivers/SmartThings/matter-switch/src/switch_utils/device_configuration.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,16 @@ function SwitchDeviceConfiguration.assign_profile_for_onoff_ep(device, server_on
or switch_utils.find_max_subset_device_type(ep_info, fields.DEVICE_TYPE_ID.SWITCH)
or switch_utils.find_primary_device_type(ep_info)

-- some devices purporting to be COLOR_TEMPERATURE may actually expose EXTENDED_COLOR feature bits
if primary_dt_id == fields.DEVICE_TYPE_ID.LIGHT.COLOR_TEMPERATURE then
local color_control_ep = switch_utils.find_cluster_on_ep(ep_info, clusters.ColorControl.ID) or {}
local color_control_feature_map = color_control_ep.feature_map or 0
if clusters.ColorControl.are_features_supported(clusters.ColorControl.types.Feature.XY, color_control_feature_map) or
clusters.ColorControl.are_features_supported(clusters.ColorControl.types.Feature.HUE_AND_SATURATION, color_control_feature_map) then
primary_dt_id = fields.DEVICE_TYPE_ID.LIGHT.EXTENDED_COLOR
end
end

local generic_profile = fields.device_type_profile_map[primary_dt_id]

local static_electrical_tags = switch_utils.get_field_for_endpoint(device, fields.ELECTRICAL_TAGS, server_onoff_ep_id)
Expand Down
Loading