add wallhero_thermostat_ACL-403STC1

[thinkaName]

Check all that apply

Type of Change

• WWST Certification Request
  • If this is your first time contributing code:
    • I have reviewed the README.md file
    • I have reviewed the CODE_OF_CONDUCT.md file
    • I have signed the CLA
  • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
• Bug fix
• New feature
• Refactor

Checklist

• I have performed a self-review of my code
• I have commented my code in hard-to-understand areas
• I have verified my changes by testing with a device or have communicated a plan for testing
• I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

[github-actions]

Duplicate profile check: Passed - no duplicate profiles detected.

[github-actions]

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/NxlwxaR7K4jA

[github-actions]

Test Results

   73 files    517 suites   0s ⏱️
2 944 tests 2 944 ✅ 0 💤 0 ❌
4 851 runs  4 851 ✅ 0 💤 0 ❌

Results for commit 8d2206d.

♻️ This comment has been updated with latest results.

[github-actions]

File	Coverage
All files	95%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/aqara/init.lua	94%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/wallhero/init.lua	96%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro/init.lua	87%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/resideo_korea/init.lua	90%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/popp/init.lua	92%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/zenwithin/init.lua	97%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/sinope/init.lua	97%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/vimar/init.lua	89%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro-ki-zigbee-thermostat/init.lua	96%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/init.lua	97%	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lazy_load_subdriver.lua	57%	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lux-konoz/can_handle.lua	83%	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 8d2206d

[cbaumler]

Hi @thinkaName, it looks like this PR branch is out of date with main. Please update it with the latest main and push the result. Then we can re-review.

[cbaumler]

Hi @thinkaName, it looks like this PR branch is out of date with main again. Please update it with the latest main and push the result. Then let us know when you're ready for us to re-review.

[thinkaName]

Hi @thinkaName, it looks like this PR branch is out of date with main again. Please update it with the latest main and push the result. Then let us know when you're ready for us to re-review.

It ready to re-review.

[cbaumler]

@aleclorimer could you take another look?

[cbaumler]

Hi @thinkaName , it looks like this PR branch is out of date with main again. Please update it with the latest main and push the result so it can be merged once it is approved.

[thinkaName]

Hi @thinkaName , it looks like this PR branch is out of date with main again. Please update it with the latest main and push the result so it can be merged once it is approved.

It ready to re-review.

[aleclorimer]

LGTM. Merge conflict needs to be resolved. Lastly, please push incremental commits rather than squashing all commits. It will make it easier to review new commits and improvements quicker!

[hcarter-775]

@thinkaName

LGTM. Merge conflict needs to be resolved. Lastly, please push incremental commits rather than squashing all commits. It will make it easier to review new commits and improvements quicker!

Adding to this, I recall you mentioning that you were doing this because we'd mentioned wanting only one commit to be merged at the end of this, and this is true! However, you can more easily do that at the very end of the process by either squashing all commits at the very end, before merging, or by using the "squash and merge" option in the github UI directly. Either of these options will allow there to be "one commit merged" while leaving commits open during the review process.

Thanks!