Skip to content

Latest Zigbee Lock Migration#2956

Open
hcarter-775 wants to merge 25 commits into
mainfrom
re-create/chad-16364
Open

Latest Zigbee Lock Migration#2956
hcarter-775 wants to merge 25 commits into
mainfrom
re-create/chad-16364

Conversation

@hcarter-775
Copy link
Copy Markdown
Contributor

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

cbaumler and others added 22 commits May 1, 2026 09:33
First, I had AI do the following:
- Rename subdrivers: using-old-capabilities -> legacy-handlers,
  promote using-new-capabilities handlers to top-level defaults
- Make new capability handling the driver default; legacy-handlers
  subdriver overrides for pre-migration devices only
- Top-level vendor subdrivers (yale, samsungsds, yale-fingerprint-lock)
  now only activate for migrated devices to avoid double-dispatch
- Remove duplicate lock-without-codes top-level subdriver (handled
  entirely within legacy-handlers since these devices never migrate)
- Add init lifecycle handler to legacy-handlers to populate lockCodes
  state for pre-migration devices on driver restart

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Then, I cleaned up the driver further by fixing the git understanding of
what files were made in what year, and by introducing small changes to
altogether remove some sub-subdrivers from the legacy subdriver, and vice versa.
@github-actions
Copy link
Copy Markdown

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Test Results

   72 files    513 suites   0s ⏱️
2 919 tests 2 919 ✅ 0 💤 0 ❌
4 784 runs  4 784 ✅ 0 💤 0 ❌

Results for commit 3f8ef87.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

File Coverage
All files 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/init.lua 99%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/configurations.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_handlers/zigbee_responses.lua 73%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_handlers/capabilities.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils/utils.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/lock_utils/tables.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/legacy-handlers/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-lock/src/legacy-handlers/yale/init.lua 92%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 3f8ef87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants