Skip to content

Conversation

@aleclorimer
Copy link
Contributor

Lazy loading of sub-drivers for zwave thermostat. Required some manual intervention to fix some subdrivers. Passing all unit tests now.

@github-actions
Copy link

@github-actions
Copy link

Test Results

   71 files    469 suites   0s ⏱️
2 457 tests 2 457 ✅ 0 💤 0 ❌
4 177 runs  4 177 ✅ 0 💤 0 ❌

Results for commit 88fa1fc.

@github-actions
Copy link

File Coverage
All files 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/stelpro-ki-thermostat/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/aeotec-radiator-thermostat/init.lua 77%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/popp-radiator-thermostat/init.lua 84%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/fibaro-heat-controller/init.lua 76%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/ct100-thermostat/init.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/can_handle.lua 35%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/thermostat-heating-battery/init.lua 93%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 88fa1fc

end
end

return can_handle_aeotec_radiator_thermostat No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

{ manufacturerId = 0x0002, productType = 0x0005, productId = 0x0004 } -- Danfoss LC13 Thermostat
}

return DANFOSS_LC13_THERMOSTAT_FPS No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably remove this, as apiv6 was from awhile ago and there probably arent any more hubs with this version. Can you write a ticket?

@greens
Copy link
Contributor

greens commented Nov 25, 2025

Checking drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/can_handle.lua 3 warnings

    drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/can_handle.lua:7:1: (W611) line contains only whitespace
    drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/can_handle.lua:9:22: (W113) accessing undefined variable cc
    drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/can_handle.lua:10:19: (W113) accessing undefined variable WakeUp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants