-
Notifications
You must be signed in to change notification settings - Fork 520
Zwave thermostat lazy load subdrivers #2582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Invitation URL: |
Test Results 71 files 469 suites 0s ⏱️ Results for commit 88fa1fc. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 88fa1fc |
| end | ||
| end | ||
|
|
||
| return can_handle_aeotec_radiator_thermostat No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
| { manufacturerId = 0x0002, productType = 0x0005, productId = 0x0004 } -- Danfoss LC13 Thermostat | ||
| } | ||
|
|
||
| return DANFOSS_LC13_THERMOSTAT_FPS No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably remove this, as apiv6 was from awhile ago and there probably arent any more hubs with this version. Can you write a ticket?
|
Lazy loading of sub-drivers for zwave thermostat. Required some manual intervention to fix some subdrivers. Passing all unit tests now.