Add light-level-fan profile #2581
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcarter-775
requested review from
ctowns,
gharveymn,
greens and
nickolas-deboom
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
Test Results 71 files 469 suites 0s ⏱️ Results for commit 6f7e2d5. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 6f7e2d5 |
| local generic_profile = function(s) return string.find(updated_profile or "", s, 1, true) end | ||
| if generic_profile("plug-binary") or generic_profile("plug-level") then | ||
| if (generic_profile("plug-binary") or generic_profile("light-binary")) and fan_control_supported then | ||
| updated_profile = "switch-fan" |
Contributor
There was a problem hiding this comment.
Does this profile exist already? I don't see it
Contributor
Author
There was a problem hiding this comment.
whoops, did some copy pasting from this PR where that guy does exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add light-level-fan profile
Summary of Completed Tests