Skip to content

Investigation: fibaro keyfob not producing down_hold and pushed_3x ev… #2574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Investigation: fibaro keyfob not producing down_hold and pushed_3x ev… #2574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion drivers/SmartThings/zwave-button/src/test/test_zwave_multi_button.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ local capabilities = require "st.capabilities"
local zw = require "st.zwave"
local zw_test_utils = require "integration_test.zwave_test_utils"
local Battery = (require "st.zwave.CommandClass.Battery")({ version=1 })
local CentralScene = (require "st.zwave.CommandClass.CentralScene")({ version=1 })
local CentralScene = (require "st.zwave.CommandClass.CentralScene")({ version=3 })
local SceneActivation = (require "st.zwave.CommandClass.SceneActivation")({ version = 1 })
local Configuration = (require "st.zwave.CommandClass.Configuration")({ version = 4 })
local Association = (require "st.zwave.CommandClass.Association")({ version = 1 })
Expand Down Expand Up @@ -719,6 +719,28 @@ test.register_coroutine_test(
Battery:Get({})
)
)

test.wait_for_events()
test.socket.zwave:__queue_receive({
mock_fibaro_keyfob_button.id,
CentralScene:Notification(
{
key_attributes = CentralScene.key_attributes.KEY_PRESSED_3_TIMES, scene_number=1, sequence_number=8, slow_refresh=true
}
)
})
test.socket.capability:__expect_send(
mock_fibaro_keyfob_button:generate_test_message(
"main",
capabilities.button.button.pushed_3x({ state_change = true })
)
)
test.socket.capability:__expect_send(
mock_fibaro_keyfob_button:generate_test_message(
"button1",
capabilities.button.button.pushed_3x({ state_change = true })
)
)
end
)

Expand Down
6 changes: 6 additions & 0 deletions drivers/SmartThings/zwave-button/src/zwave-multi-button/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ local cc = require "st.zwave.CommandClass"
local CentralScene = (require "st.zwave.CommandClass.CentralScene")({ version=1 })
--- @type st.zwave.CommandClass.SceneActivation
local SceneActivation = (require "st.zwave.CommandClass.SceneActivation")({ version=1 })
local log = require "log"
local utils = require "st.utils"

local ZWAVE_MULTI_BUTTON_FINGERPRINTS = {
{mfr = 0x010F, prod = 0x1001, model = 0x1000}, -- Fibaro KeyFob EU
Expand Down Expand Up @@ -67,7 +69,11 @@ local function central_scene_notification_handler(self, device, cmd)
capabilities.button.supportedButtonValues.NAME,
{capabilities.button.button.pushed.NAME, capabilities.button.button.held.NAME} -- default value
)
log.debug("COMPONENT: "..device:endpoint_to_component(cmd.args.scene_number))
log.debug("SUPPORTED EVENTS: " .. utils.stringify_table(supportedEvents))
for _, event_name in pairs(supportedEvents) do
log.debug("EVENT_NAME: " .. event_name)
log.debug("EVENT VALUE: " .. event.value.value)
if event.value.value == event_name then
device:emit_event_for_endpoint(cmd.args.scene_number, event)
device:emit_event(event)
Expand Down
Loading