Skip to content

Fix for integer overflow when using Configuration:Set #2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix for integer overflow when using Configuration:Set #2557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad84550
Fix for integer overflow
rboy1 Nov 16, 2025
5a4a454
Fix for integer overflow
rboy1 Nov 16, 2025
18f3ba5
Merge pull request #1 from rboy1/patch-2
rboy1 Nov 16, 2025
b5938b1
Merge pull request #2 from rboy1/patch-3
rboy1 Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion drivers/SmartThings/zwave-switch/src/aeotec-heavy-duty/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ local cc = require "st.zwave.CommandClass"
local Configuration = (require "st.zwave.CommandClass.Configuration")({ version = 4 })

local preferencesMap = require "preferences"
local utils = require "st.utils"


local LAST_REPORT_TIME = "LAST_REPORT_TIME"
Expand Down Expand Up @@ -79,7 +80,7 @@ local function info_changed(driver, device, event, args)
device:send(Configuration:Set({
parameter_number = preferences[id].parameter_number,
size = preferences[id].size,
configuration_value = new_parameter_value
configuration_value = utils.unsigned_to_signed(new_parameter_value, preferences[id].size)
}))
end
end
Expand Down
5 changes: 3 additions & 2 deletions drivers/SmartThings/zwave-switch/src/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ local Configuration = (require "st.zwave.CommandClass.Configuration")({ version
local SwitchMultilevel = (require "st.zwave.CommandClass.SwitchMultilevel")({ version = 4 })
local preferencesMap = require "preferences"
local configurationsMap = require "configurations"
local utils = require "st.utils"

local lazy_load_if_possible = require "lazy_load_subdriver"

Expand Down Expand Up @@ -65,7 +66,7 @@ local function info_changed(driver, device, event, args)
for id, value in pairs(device.preferences) do
if args.old_st_store.preferences[id] ~= value and preferences and preferences[id] then
local new_parameter_value = preferencesMap.to_numeric_value(device.preferences[id])
device:send(Configuration:Set({ parameter_number = preferences[id].parameter_number, size = preferences[id].size, configuration_value = new_parameter_value }))
device:send(Configuration:Set({ parameter_number = preferences[id].parameter_number, size = preferences[id].size, configuration_value = utils.unsigned_to_signed(new_parameter_value, preferences[id].size) }))
end
end
end
Expand All @@ -78,7 +79,7 @@ local function do_configure(driver, device)
local configuration = configurationsMap.get_device_configuration(device)
if configuration ~= nil then
for _, value in ipairs(configuration) do
device:send(Configuration:Set({ parameter_number = value.parameter_number, size = value.size, configuration_value = value.configuration_value }))
device:send(Configuration:Set({ parameter_number = value.parameter_number, size = value.size, configuration_value = utils.unsigned_to_signed(value.configuration_value, value.size) }))
end
end
end
Expand Down